xfa/fxfa/parser/xfa_document_serialize.cpp - Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_document_serialize.cpp

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Use "At" for arrays. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/xfa_document_serialize.cpp

diff --git a/xfa/fxfa/parser/xfa_document_serialize.cpp b/xfa/fxfa/parser/xfa_document_serialize.cpp

index 3df82e38f1f47c0c9b0091fda78fac199a6edb7e..5cff9936e283ea0c3f0ec78599e383e833602d32 100644

--- a/xfa/fxfa/parser/xfa_document_serialize.cpp

+++ b/xfa/fxfa/parser/xfa_document_serialize.cpp

@@ -211,7 +211,8 @@ static void XFA_DataExporter_RegenerateFormFile_Changed(

FX_BOOL bSaveXML = FALSE) {

CFX_WideString wsAttrs;

int32_t iAttrs = 0;

- const uint8_t* pAttrs = XFA_GetElementAttributes(pNode->GetClassID(), iAttrs);

+ const uint8_t* pAttrs =

+ XFA_GetObjectByAttributes(pNode->GetClassID(), iAttrs);

while (iAttrs--) {

const XFA_ATTRIBUTEINFO* pAttr =

XFA_GetAttributeByID((XFA_ATTRIBUTE)pAttrs[iAttrs]);

@@ -396,7 +397,8 @@ static void XFA_DataExporter_RegenerateFormFile_Container(

wsOutput);