xfa/fxfa/parser/xfa_basic_data.cpp - Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_basic_data.cpp

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Use "At" for arrays. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/xfa_basic_data.cpp

diff --git a/xfa/fxfa/parser/xfa_basic_data.cpp b/xfa/fxfa/parser/xfa_basic_data.cpp

index f8a26dc1cd6554ebbe6f4ada149ac21d3797d180..6df07f420a4ea1bacaa64315930b3edfa9e31be6 100644

--- a/xfa/fxfa/parser/xfa_basic_data.cpp

+++ b/xfa/fxfa/parser/xfa_basic_data.cpp

@@ -4082,7 +4082,7 @@ const XFA_METHODINFO g_SomMethodData[] = {

{0x9c456500, L"saveXML",

(XFA_METHOD_CALLBACK)&CXFA_Node::Script_NodeClass_SaveXML},

{0xabd3200a, L"getElement",

- (XFA_METHOD_CALLBACK)&CXFA_Node::Script_NodeClass_GetElement},

+ (XFA_METHOD_CALLBACK)&CXFA_Node::Script_NodeClass_GetObjectBy},

{0xb269c60d, L"isPropertySpecified",

(XFA_METHOD_CALLBACK)&CXFA_Node::Script_NodeClass_IsPropertySpecified},

{0xb528be91, L"loadXML",