Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: fpdfsdk/javascript/color.cpp

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Use "At" for arrays. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fpdfsdk/javascript/color.cpp
diff --git a/fpdfsdk/javascript/color.cpp b/fpdfsdk/javascript/color.cpp
index 2681a8693e53dbd9881c2daf877ebc4111858b29..21acfcf085caf03dda5b69e01dc1e449877825ef 100644
--- a/fpdfsdk/javascript/color.cpp
+++ b/fpdfsdk/javascript/color.cpp
@@ -91,7 +91,7 @@ void color::ConvertArrayToPWLColor(CJS_Array& array, CPWL_Color& color) {
return;
CJS_Value value(array.GetJSRuntime());
- array.GetElement(0, value);
+ array.GetObjectBy(0, value);
CFX_ByteString sSpace = value.ToCFXByteString();
double d1 = 0;
@@ -100,22 +100,22 @@ void color::ConvertArrayToPWLColor(CJS_Array& array, CPWL_Color& color) {
double d4 = 0;
if (nArrayLen > 1) {
- array.GetElement(1, value);
+ array.GetObjectBy(1, value);
d1 = value.ToDouble();
}
if (nArrayLen > 2) {
- array.GetElement(2, value);
+ array.GetObjectBy(2, value);
d2 = value.ToDouble();
}
if (nArrayLen > 3) {
- array.GetElement(3, value);
+ array.GetObjectBy(3, value);
d3 = value.ToDouble();
}
if (nArrayLen > 4) {
- array.GetElement(4, value);
+ array.GetObjectBy(4, value);
d4 = value.ToDouble();
}

Powered by Google App Engine
This is Rietveld 408576698