fpdfsdk/fpdf_transformpage.cpp - Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdf_transformpage.cpp

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Use "At" for arrays. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdf_transformpage.cpp

diff --git a/fpdfsdk/fpdf_transformpage.cpp b/fpdfsdk/fpdf_transformpage.cpp

index 23118b4c3fbb9e4e302fa07d7b99143d4e9e557a..d47cb02b1d3ffd5eb50790070ac9d30788d87242 100644

--- a/fpdfsdk/fpdf_transformpage.cpp

+++ b/fpdfsdk/fpdf_transformpage.cpp

@@ -120,7 +120,7 @@ DLLEXPORT FPDF_BOOL STDCALL FPDFPage_TransFormWithClip(FPDF_PAGE page,

CPDF_Dictionary* pPageDic = pPage->m_pFormDict;

CPDF_Object* pContentObj =

- pPageDic ? pPageDic->GetElement("Contents") : nullptr;

+ pPageDic ? pPageDic->GetObjectBy("Contents") : nullptr;

if (!pContentObj)

pContentObj = pPageDic ? pPageDic->GetArrayBy("Contents") : nullptr;

if (!pContentObj)

@@ -277,7 +277,7 @@ DLLEXPORT void STDCALL FPDFPage_InsertClipPath(FPDF_PAGE page,

CPDF_Dictionary* pPageDic = pPage->m_pFormDict;

CPDF_Object* pContentObj =

- pPageDic ? pPageDic->GetElement("Contents") : nullptr;

+ pPageDic ? pPageDic->GetObjectBy("Contents") : nullptr;

if (!pContentObj)

pContentObj = pPageDic ? pPageDic->GetArrayBy("Contents") : nullptr;

if (!pContentObj)