Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: fpdfsdk/fpdf_ext.cpp

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Use "At" for arrays. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fpdfsdk/fpdf_ext.cpp
diff --git a/fpdfsdk/fpdf_ext.cpp b/fpdfsdk/fpdf_ext.cpp
index 2541bddb50817398ffa6d2ed28a5d4e053c50632..a199cfc9e778fa2d795509cd3f6de2f48154a9fa 100644
--- a/fpdfsdk/fpdf_ext.cpp
+++ b/fpdfsdk/fpdf_ext.cpp
@@ -104,7 +104,7 @@ FX_BOOL CheckSharedForm(const CXML_Element* pElement, CFX_ByteString cbName) {
pElement->GetAttrByIndex(i, space, name, value);
if (space == "xmlns" && name == "adhocwf" &&
value == L"http://ns.adobe.com/AcrobatAdhocWorkflow/1.0/") {
- CXML_Element* pVersion = pElement->GetElement("adhocwf", cbName);
+ CXML_Element* pVersion = pElement->GetObjectBy("adhocwf", cbName);
if (!pVersion)
continue;
CFX_WideString wsContent = pVersion->GetContent(0); // == 1.1
@@ -127,7 +127,7 @@ FX_BOOL CheckSharedForm(const CXML_Element* pElement, CFX_ByteString cbName) {
for (i = 0; i < (int)nCount; i++) {
CXML_Element::ChildType childType = pElement->GetChildType(i);
if (childType == CXML_Element::Element) {
- CXML_Element* pChild = pElement->GetElement(i);
+ CXML_Element* pChild = pElement->GetObjectBy(i);
if (CheckSharedForm(pChild, cbName))
return TRUE;
}
@@ -200,7 +200,7 @@ DLLEXPORT int FPDFDoc_GetPageMode(FPDF_DOCUMENT document) {
if (!pRoot)
return PAGEMODE_UNKNOWN;
- CPDF_Object* pName = pRoot->GetElement("PageMode");
+ CPDF_Object* pName = pRoot->GetObjectBy("PageMode");
if (!pName)
return PAGEMODE_USENONE;

Powered by Google App Engine
This is Rietveld 408576698