core/fpdfdoc/doc_link.cpp - Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/doc_link.cpp

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Use "At" for arrays. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/doc_link.cpp

diff --git a/core/fpdfdoc/doc_link.cpp b/core/fpdfdoc/doc_link.cpp

index 3f97024237273b733c8168a8ef6edc9a71ab83c3..723955f9eacc55c99c9d465a0cdf8d5fd30baf37 100644

--- a/core/fpdfdoc/doc_link.cpp

+++ b/core/fpdfdoc/doc_link.cpp

@@ -75,7 +75,7 @@ CFX_FloatRect CPDF_Link::GetRect() {

return m_pDict->GetRectBy("Rect");

}

CPDF_Dest CPDF_Link::GetDest(CPDF_Document* pDoc) {

- CPDF_Object* pDest = m_pDict->GetElementValue("Dest");

+ CPDF_Object* pDest = m_pDict->GetDirectObjectBy("Dest");

if (!pDest)

return CPDF_Dest();