core/fpdfapi/fpdf_page/cpdf_page.cpp - Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/cpdf_page.cpp

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Use "At" for arrays. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_page/cpdf_page.cpp

diff --git a/core/fpdfapi/fpdf_page/cpdf_page.cpp b/core/fpdfapi/fpdf_page/cpdf_page.cpp

index 6fd9b0a9b33b7e312abecb2220d8893c3ab9042e..dd298f382facad69d8496d7faa24e0ebb7e43b12 100644

--- a/core/fpdfapi/fpdf_page/cpdf_page.cpp

+++ b/core/fpdfapi/fpdf_page/cpdf_page.cpp

@@ -18,7 +18,7 @@ CPDF_Object* FPDFAPI_GetPageAttr(CPDF_Dictionary* pPageDict,

const CFX_ByteStringC& name) {

int level = 0;

while (1) {

- CPDF_Object* pObj = pPageDict->GetElementValue(name);

+ CPDF_Object* pObj = pPageDict->GetDirectObjectBy(name);

if (pObj) {

return pObj;

}