Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 1841153002: BrowserCompositorMac, ResizeLock, DelegatedFrameHost => content/browser/renderer_host (Closed)

Created:
4 years, 8 months ago by Fady Samuel
Modified:
4 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org, danakj, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BrowserCompositorMac, ResizeLock, DelegatedFrameHost => content/browser/renderer_host In the future, content/browser/compositor will likely be moved to components/display_compositor. In anticipation of that move, I'm moving files that are content specific to content/browser/renderer_host. BUG=598792 Committed: https://crrev.com/6168175d0420c55052f79fe1113c8270c163cd8f Cr-Commit-Position: refs/heads/master@{#383850}

Patch Set 1 #

Patch Set 2 : Rebased git cl format #

Patch Set 3 : Fixed Mac Build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1592 lines) Patch
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/compositor/browser_compositor_view_mac.h View 1 chunk +0 lines, -78 lines 0 comments Download
D content/browser/compositor/browser_compositor_view_mac.mm View 1 chunk +0 lines, -120 lines 0 comments Download
D content/browser/compositor/delegated_frame_host.h View 1 chunk +0 lines, -325 lines 0 comments Download
D content/browser/compositor/delegated_frame_host.cc View 1 chunk +0 lines, -907 lines 0 comments Download
D content/browser/compositor/resize_lock.h View 1 chunk +0 lines, -37 lines 0 comments Download
D content/browser/compositor/resize_lock.cc View 1 chunk +0 lines, -35 lines 0 comments Download
A + content/browser/renderer_host/browser_compositor_view_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/renderer_host/browser_compositor_view_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_resize_lock_aura.h View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/renderer_host/delegated_frame_host.h View 1 4 chunks +5 lines, -6 lines 0 comments Download
A + content/browser/renderer_host/delegated_frame_host.cc View 1 18 chunks +33 lines, -56 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/renderer_host/resize_lock.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/renderer_host/resize_lock.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M content/test/content_browser_test_utils_internal.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (12 generated)
Fady Samuel
4 years, 8 months ago (2016-03-29 18:50:16 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841153002/1
4 years, 8 months ago (2016-03-29 18:50:30 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/10426) ios_rel_device_gn on ...
4 years, 8 months ago (2016-03-29 18:53:08 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841153002/20001
4 years, 8 months ago (2016-03-29 19:21:44 UTC) #9
Fady Samuel
+rjkroege@ for content/browser/renderer_host.
4 years, 8 months ago (2016-03-29 19:22:10 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/179328)
4 years, 8 months ago (2016-03-29 19:34:40 UTC) #13
Fady Samuel
+piman@ to get full content/ review coverage. Moving danakj@, and rjkroege@ to cc.
4 years, 8 months ago (2016-03-29 19:45:15 UTC) #15
piman
lgtm
4 years, 8 months ago (2016-03-29 19:58:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841153002/40001
4 years, 8 months ago (2016-03-29 21:03:54 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-29 22:29:31 UTC) #21
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 22:30:51 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6168175d0420c55052f79fe1113c8270c163cd8f
Cr-Commit-Position: refs/heads/master@{#383850}

Powered by Google App Engine
This is Rietveld 408576698