Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184113005: Removal of drag window to user tray icon functionality (Closed)

Created:
6 years, 9 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, dcheng, ben+ash_chromium.org
Visibility:
Public.

Description

Removal of drag window to user tray icon functionality BUG=348133 TEST=let it run and compiled - removal of code Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254435

Patch Set 1 #

Total comments: 6

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -474 lines) Patch
M ash/ash_switches.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ash/ash_switches.cc View 1 2 chunks +0 lines, -13 lines 0 comments Download
M ash/session_state_delegate.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ash/session_state_delegate_stub.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/session_state_delegate_stub.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ash/system/tray/system_tray.h View 3 chunks +0 lines, -11 lines 0 comments Download
M ash/system/tray/system_tray.cc View 3 chunks +3 lines, -14 lines 0 comments Download
M ash/system/user/tray_user.h View 1 3 chunks +0 lines, -12 lines 0 comments Download
M ash/system/user/tray_user.cc View 1 10 chunks +10 lines, -92 lines 0 comments Download
M ash/system/user/tray_user_unittest.cc View 1 3 chunks +0 lines, -70 lines 0 comments Download
M ash/test/test_session_state_delegate.h View 3 chunks +0 lines, -11 lines 0 comments Download
M ash/test/test_session_state_delegate.cc View 2 chunks +1 line, -9 lines 0 comments Download
M ash/wm/drag_window_resizer.h View 2 chunks +0 lines, -9 lines 0 comments Download
M ash/wm/drag_window_resizer.cc View 5 chunks +0 lines, -72 lines 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 2 chunks +0 lines, -94 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 1 2 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_views.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_views.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
Mr4D (OOO till 08-26)
Removing this feature which I really liked - but not UX. Sniff. Since you asked ...
6 years, 9 months ago (2014-02-28 22:57:44 UTC) #1
oshima
lgtm with nits https://codereview.chromium.org/184113005/diff/1/ash/system/user/tray_user.h File ash/system/user/tray_user.h (right): https://codereview.chromium.org/184113005/diff/1/ash/system/user/tray_user.h#newcode16 ash/system/user/tray_user.h:16: class Point; this is no longer ...
6 years, 9 months ago (2014-02-28 23:29:33 UTC) #2
Mr4D (OOO till 08-26)
Done. Thanks! https://codereview.chromium.org/184113005/diff/1/ash/system/user/tray_user.h File ash/system/user/tray_user.h (right): https://codereview.chromium.org/184113005/diff/1/ash/system/user/tray_user.h#newcode16 ash/system/user/tray_user.h:16: class Point; On 2014/02/28 23:29:33, oshima wrote: ...
6 years, 9 months ago (2014-03-01 17:21:34 UTC) #3
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 9 months ago (2014-03-01 17:22:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/184113005/20001
6 years, 9 months ago (2014-03-01 17:22:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-01 18:18:14 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=80504
6 years, 9 months ago (2014-03-01 18:18:15 UTC) #7
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 9 months ago (2014-03-01 18:22:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/184113005/20001
6 years, 9 months ago (2014-03-01 18:22:35 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-01 19:04:27 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=80514
6 years, 9 months ago (2014-03-01 19:04:28 UTC) #11
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 9 months ago (2014-03-01 19:15:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/184113005/20001
6 years, 9 months ago (2014-03-01 19:15:27 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-01 20:00:33 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=80520
6 years, 9 months ago (2014-03-01 20:00:34 UTC) #15
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 9 months ago (2014-03-01 22:23:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/184113005/20001
6 years, 9 months ago (2014-03-01 22:24:01 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-01 23:11:44 UTC) #18
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=80556
6 years, 9 months ago (2014-03-01 23:11:45 UTC) #19
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 9 months ago (2014-03-02 16:24:44 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/184113005/20001
6 years, 9 months ago (2014-03-02 16:24:51 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-02 17:13:53 UTC) #22
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=80672
6 years, 9 months ago (2014-03-02 17:13:54 UTC) #23
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 9 months ago (2014-03-03 02:28:21 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/184113005/20001
6 years, 9 months ago (2014-03-03 02:28:33 UTC) #25
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 07:52:07 UTC) #26
Message was sent while issue was closed. 
Change committed as 254435

Powered by Google App Engine
This is Rietveld 408576698