Reverse dependency between SkScalar.h and SkFixed.h

Reverse dependency between SkScalar.h and SkFixed.h.

The following are unused in Chromium, Android, Mozilla, and Google3:
 - SkFixedToScalar
 - SkScalarToFixed

The following are additionally unused in Skia:
 - SkStrAppendFixed
 - SkWriteBuffer::writeFixed

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1841123002

Committed: https://skia.googlesource.com/skia/+/6c71e0a065c2eb32139682bb1ca1cbbeb02ebcb9

[dogben, 2016-03-29 18:12:23]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 18:12:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841123002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841123002/1

[dogben, 2016-03-29 18:12:37]

Description was changed from

==========
Move SkFixed.h to src.

BUG=skia:
==========

to

==========
Move SkFixed.h to src.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-03-29 18:23:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 18:23:26]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-03-29 19:03:29]

Description was changed from

==========
Move SkFixed.h to src.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Move SkFixed.h to src.

The following are unused in Chromium, Android, Mozilla, and Google3:
 - SkFixedToScalar
 - SkScalarToFixed

The following are additionally unused in Skia:
 - SkStrAppendFixed
 - SkWriteBuffer::writeFixed
 - SkRandom::nextUFixed1 (after this CL)
 - SkRandom::nextSFixed1 (after this CL)

Before this CL, SkRandom::nextSScalar1, LCGRandom::nextSScalar1, and
LCGRandom::nextSFixed1 appear to me by examination to return a number in the
range [-1, 1), so I updated the documentation to reflect that.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[dogben, 2016-03-29 22:57:26]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 22:57:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841123002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841123002/20001

[commit-bot: I haz the power, 2016-03-29 23:07:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 23:07:59]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-03-31 20:44:59]

Description was changed from

==========
Move SkFixed.h to src.

The following are unused in Chromium, Android, Mozilla, and Google3:
 - SkFixedToScalar
 - SkScalarToFixed

The following are additionally unused in Skia:
 - SkStrAppendFixed
 - SkWriteBuffer::writeFixed
 - SkRandom::nextUFixed1 (after this CL)
 - SkRandom::nextSFixed1 (after this CL)

Before this CL, SkRandom::nextSScalar1, LCGRandom::nextSScalar1, and
LCGRandom::nextSFixed1 appear to me by examination to return a number in the
range [-1, 1), so I updated the documentation to reflect that.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Reverse dependency between SkScalar.h and SkFixed.h.

The following are unused in Chromium, Android, Mozilla, and Google3:
 - SkFixedToScalar
 - SkScalarToFixed

The following are additionally unused in Skia:
 - SkStrAppendFixed
 - SkWriteBuffer::writeFixed

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[dogben, 2016-03-31 20:44:59]

benjaminwagner@google.com changed reviewers:
+ reed@google.com

[dogben, 2016-03-31 20:45:07]

Patchset #1 (id:1) has been deleted

[dogben, 2016-03-31 20:45:14]

Patchset #1 (id:20001) has been deleted

[dogben, 2016-03-31 20:45:18]

Patchset #1 (id:40001) has been deleted

[dogben, 2016-03-31 20:45:25]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 20:45:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841123002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841123002/60001

[commit-bot: I haz the power, 2016-04-01 11:50:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 11:50:29]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-04-07 14:51:21]

reed, PTAL due to API changes. (These APIs are not currently used.)

[reed1, 2016-04-07 15:11:47]

do we really need it in include at all, and not in src/core ?

[dogben, 2016-04-07 15:24:06]

On 2016/04/07 at 15:11:47, reed wrote:
> do we really need it in include at all, and not in src/core ?

I tried. Unfortunately, SkRandom.h uses SkFixed, and GrTestUtils.h and
GrProcessorUnitTest.h use SkRandom. I also tried changing SkRandom::nextUScalar1
and SkRandom::nextSScalar1 to use SkRandom::nextF, but there are several
non-test uses of SkRandom that change in ways I can't verify are correct.

[reed1, 2016-04-07 15:29:47]

api lgtm

later I'd be curious if we can move it to src/core

[dogben, 2016-04-07 15:34:24]

The CQ bit was checked by benjaminwagner@google.com

[commit-bot: I haz the power, 2016-04-07 15:34:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841123002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841123002/60001

[commit-bot: I haz the power, 2016-04-07 15:49:36]

Description was changed from

==========
Reverse dependency between SkScalar.h and SkFixed.h.

The following are unused in Chromium, Android, Mozilla, and Google3:
 - SkFixedToScalar
 - SkScalarToFixed

The following are additionally unused in Skia:
 - SkStrAppendFixed
 - SkWriteBuffer::writeFixed

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Reverse dependency between SkScalar.h and SkFixed.h.

The following are unused in Chromium, Android, Mozilla, and Google3:
 - SkFixedToScalar
 - SkScalarToFixed

The following are additionally unused in Skia:
 - SkStrAppendFixed
 - SkWriteBuffer::writeFixed

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6c71e0a065c2eb32139682bb1ca1cbbeb02ebcb9
==========

[commit-bot: I haz the power, 2016-04-07 15:49:37]

Committed patchset #1 (id:60001) as
https://skia.googlesource.com/skia/+/6c71e0a065c2eb32139682bb1ca1cbbeb02ebcb9