Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 18411005: Use the async version of WebFileSystem::createFileWriter (Closed)

Created:
7 years, 5 months ago by kinuko
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, kinuko, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Use the async version of WebFileSystem::createFileWriter Removing unnecessary callback chain. (Some worker code still rely on the old createFileWriter, but they're supposed to go away) This depends on chrome-side patch: https://codereview.chromium.org/18427005/ BUG=257349 TEST=no behavioral changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154363

Patch Set 1 : #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -67 lines) Patch
M Source/web/AsyncFileSystemChromium.cpp View 1 chunk +4 lines, -64 lines 0 comments Download
M Source/web/AsyncFileWriterChromium.h View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/web/AsyncFileWriterChromium.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/web/WebFileSystemCallbacksImpl.h View 4 chunks +6 lines, -0 lines 0 comments Download
M Source/web/WebFileSystemCallbacksImpl.cpp View 4 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kinuko
PTL
7 years, 5 months ago (2013-07-12 05:10:06 UTC) #1
abarth-chromium
LGTM. The memory management in this CL is kind of scary to me, but ok. ...
7 years, 5 months ago (2013-07-12 22:53:48 UTC) #2
kinuko
Thanks! https://codereview.chromium.org/18411005/diff/5001/Source/web/AsyncFileSystemChromium.cpp File Source/web/AsyncFileSystemChromium.cpp (right): https://codereview.chromium.org/18411005/diff/5001/Source/web/AsyncFileSystemChromium.cpp#newcode117 Source/web/AsyncFileSystemChromium.cpp:117: m_webFileSystem->createFileWriter(path, writerClient, new WebKit::WebFileSystemCallbacksImpl(callbacks, asyncFileWriter.release())); On 2013/07/12 22:53:48, ...
7 years, 5 months ago (2013-07-16 02:35:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/18411005/12001
7 years, 5 months ago (2013-07-16 10:21:59 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=16974
7 years, 5 months ago (2013-07-16 12:33:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/18411005/12001
7 years, 5 months ago (2013-07-17 04:03:40 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 04:32:13 UTC) #7
Message was sent while issue was closed.
Change committed as 154363

Powered by Google App Engine
This is Rietveld 408576698