Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: ui/compositor/compositor.h

Issue 1841083007: Remove SendBeginFramesToChildren plumbing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scheduler_output_surface_client_set_beginframesource
Patch Set: Remove some comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/compositor/compositor.h
diff --git a/ui/compositor/compositor.h b/ui/compositor/compositor.h
index acae0be40c2c2d5f90a62635a5230114bf60999d..cba12b0c90443112894c85400af70c542a8e2829 100644
--- a/ui/compositor/compositor.h
+++ b/ui/compositor/compositor.h
@@ -145,13 +145,6 @@ class COMPOSITOR_EXPORT CompositorLock
DISALLOW_COPY_AND_ASSIGN(CompositorLock);
};
-// This class observes BeginFrame notification from LayerTreeHost.
-class COMPOSITOR_EXPORT CompositorBeginFrameObserver {
- public:
- virtual ~CompositorBeginFrameObserver() {}
- virtual void OnSendBeginFrame(const cc::BeginFrameArgs& args) = 0;
-};
-
// Compositor object to take care of GPU painting.
// A Browser compositor object is responsible for generating the final
// displayable form of pixels comprising a single widget's contents. It draws an
@@ -261,9 +254,6 @@ class COMPOSITOR_EXPORT Compositor
void RemoveAnimationObserver(CompositorAnimationObserver* observer);
bool HasAnimationObserver(const CompositorAnimationObserver* observer) const;
- void AddBeginFrameObserver(CompositorBeginFrameObserver* observer);
- void RemoveBeginFrameObserver(CompositorBeginFrameObserver* observer);
-
// Change the timeout behavior for all future locks that are created. Locks
// should time out if there is an expectation that the compositor will be
// responsive.
@@ -306,7 +296,6 @@ class COMPOSITOR_EXPORT Compositor
void DidCommitAndDrawFrame() override;
void DidCompleteSwapBuffers() override;
void DidCompletePageScaleAnimation() override {}
- void SendBeginFramesToChildren(const cc::BeginFrameArgs& args) override;
void RecordFrameTimingEvents(
scoped_ptr<cc::FrameTimingTracker::CompositeTimingSet> composite_events,
scoped_ptr<cc::FrameTimingTracker::MainFrameTimingSet> main_frame_events)
@@ -351,8 +340,6 @@ class COMPOSITOR_EXPORT Compositor
base::ObserverList<CompositorObserver, true> observer_list_;
base::ObserverList<CompositorAnimationObserver> animation_observer_list_;
- base::ObserverList<CompositorBeginFrameObserver, true>
- begin_frame_observer_list_;
gfx::AcceleratedWidget widget_;
bool widget_valid_;
@@ -378,9 +365,6 @@ class COMPOSITOR_EXPORT Compositor
LayerAnimatorCollection layer_animator_collection_;
scoped_refptr<cc::AnimationTimeline> animation_timeline_;
- // Used to send to any new CompositorBeginFrameObserver immediately.
- cc::BeginFrameArgs missed_begin_frame_args_;
-
base::WeakPtrFactory<Compositor> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(Compositor);

Powered by Google App Engine
This is Rietveld 408576698