Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 1841083007: Remove SendBeginFramesToChildren plumbing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scheduler_output_surface_client_set_beginframesource
Patch Set: Remove some comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.h
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h
index 05de299c6dcfa872529e5203a9da5dcf0f417568..a76c942e4bfbb38914f297cb4df0a5dd15392641 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.h
+++ b/content/browser/renderer_host/render_widget_host_view_aura.h
@@ -21,10 +21,10 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "build/build_config.h"
+#include "cc/scheduler/begin_frame_source.h"
#include "content/browser/accessibility/browser_accessibility_manager.h"
#include "content/browser/compositor/image_transport_factory.h"
#include "content/browser/compositor/owned_mailbox.h"
-#include "content/browser/renderer_host/begin_frame_observer_proxy.h"
#include "content/browser/renderer_host/delegated_frame_host.h"
#include "content/browser/renderer_host/render_widget_host_view_base.h"
#include "content/common/content_export.h"
@@ -92,14 +92,14 @@ class TouchSelectionControllerClientAura;
class CONTENT_EXPORT RenderWidgetHostViewAura
: public RenderWidgetHostViewBase,
public DelegatedFrameHostClient,
- public BeginFrameObserverProxyClient,
public ui::TextInputClient,
public gfx::DisplayObserver,
public aura::WindowTreeHostObserver,
public aura::WindowDelegate,
public aura::client::ActivationDelegate,
public aura::client::FocusChangeObserver,
- public aura::client::CursorClientObserver {
+ public aura::client::CursorClientObserver,
+ public cc::BeginFrameObserver {
public:
// When |is_guest_view_hack| is true, this view isn't really the view for
// the |widget|, a RenderWidgetHostViewGuest is.
@@ -458,9 +458,13 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
void DelegatedFrameHostUpdateVSyncParameters(
const base::TimeTicks& timebase,
const base::TimeDelta& interval) override;
+ void SetBeginFrameSource(cc::BeginFrameSource* source) override;
- // BeginFrameObserverProxyClient implementation.
- void SendBeginFrame(const cc::BeginFrameArgs& args) override;
+ // cc::BeginFrameObserver implementation.
+ void OnBeginFrame(const cc::BeginFrameArgs& args) override;
+ const cc::BeginFrameArgs& LastUsedBeginFrameArgs() const override;
+ void OnBeginFrameSourcePausedChanged(bool paused) override;
+ void AsValueInto(base::trace_event::TracedValue* dict) const override;
// Detaches |this| from the input method object.
void DetachFromInputMethod();
@@ -594,6 +598,11 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
gfx::Size last_swapped_software_frame_size_;
float last_swapped_software_frame_scale_factor_;
+ // The begin frame source being observed. Null if none.
+ cc::BeginFrameSource* begin_frame_source_;
+ cc::BeginFrameArgs last_begin_frame_args_;
+ bool observing_begin_frame_source_;
+
// If non-NULL we're in OnPaint() and this is the supplied canvas.
gfx::Canvas* paint_canvas_;
@@ -674,8 +683,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
// compositing surface and showing the disambiguation popup.
gfx::Vector2dF disambiguation_scroll_offset_;
- BeginFrameObserverProxy begin_frame_observer_proxy_;
-
// This flag when set ensures that we send over a notification to blink that
// the current view has focus. Defaults to false.
bool set_focus_on_mouse_down_or_key_event_;

Powered by Google App Engine
This is Rietveld 408576698