cc/scheduler/scheduler_state_machine.h - Issue 1841083007: Remove SendBeginFramesToChildren plumbing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/scheduler/scheduler_state_machine.h

Issue 1841083007: Remove SendBeginFramesToChildren plumbing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scheduler_output_surface_client_set_beginframesource

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/scheduler/scheduler_state_machine.h

diff --git a/cc/scheduler/scheduler_state_machine.h b/cc/scheduler/scheduler_state_machine.h

index 2d0ee144d196422a57bc8fba33ccd3a9a6c08a07..f6492e267488c0447e0b978cb471106766b26c0e 100644

--- a/cc/scheduler/scheduler_state_machine.h

+++ b/cc/scheduler/scheduler_state_machine.h

@@ -272,17 +272,11 @@ class CC_EXPORT SchedulerStateMachine {

void SetDeferCommits(bool defer_commits);

- void SetChildrenNeedBeginFrames(bool children_need_begin_frames);

- bool children_need_begin_frames() const {

- return children_need_begin_frames_;

- }

void SetVideoNeedsBeginFrames(bool video_needs_begin_frames);

bool video_needs_begin_frames() const { return video_needs_begin_frames_; }

protected:

bool BeginFrameRequiredForAction() const;

- bool BeginFrameRequiredForChildren() const;

bool BeginFrameNeededForVideo() const;

bool ProactiveBeginFrameWanted() const;

@@ -353,7 +347,6 @@ class CC_EXPORT SchedulerStateMachine {

bool critical_begin_main_frame_to_activate_is_fast_;

bool main_thread_missed_last_deadline_;

bool skip_next_begin_main_frame_to_reduce_latency_;

- bool children_need_begin_frames_;

bool defer_commits_;

bool video_needs_begin_frames_;

bool last_commit_had_no_updates_;

« no previous file with comments | « cc/scheduler/scheduler.cc ('k') | cc/scheduler/scheduler_state_machine.cc » ('j') | no next file with comments »