Change Windows 10 from SP0 to the build number.

Change Windows 10 from SP0 to the build number.

Previous: os=Windows-10-SP0
Now: os=Windows-10-10586

Call sites will need to be updated accordingly.

Next will be to add 'preview' for preview releases.

R=tandrii@chromium.org
BUG=chromium:513354
Committed: https://github.com/luci/luci-py/commit/5b9c4a499d51778c4d8061097c1a27fead760f20

[tandrii(chromium), 2016-03-29 15:46:28]

LGTM % comment

https://codereview.chromium.org/1841083002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/api/platforms/win.py (right):

https://codereview.chromium.org/1841083002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/api/platforms/win.py:158: # number.
I think this comment should be after line 160.

[M-A Ruel, 2016-03-29 15:51:53]

https://codereview.chromium.org/1841083002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/api/platforms/win.py (right):

https://codereview.chromium.org/1841083002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/api/platforms/win.py:158: # number.
On 2016/03/29 15:46:27, tandrii(chromium)-OOO wrote:
> I think this comment should be after line 160.

Agreed, moved both the line and the comment.

[M-A Ruel, 2016-03-29 15:52:36]

Description was changed from

==========
Change Windows 10 from SP0 to the build number.

Previous: os=Windows-10-SP0
Now: os=Windows-10-10586

Next will be to add 'preview' for preview releases.

R=tandrii@chromium.org
BUG=chromium:513354
==========

to

==========
Change Windows 10 from SP0 to the build number.

Previous: os=Windows-10-SP0
Now: os=Windows-10-10586

Call sites will need to be updated accordingly.

Next will be to add 'preview' for preview releases.

R=tandrii@chromium.org
BUG=chromium:513354
==========

[M-A Ruel, 2016-03-29 15:52:40]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2016-03-29 15:52:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/1841083002/#ps20001
(title: "shuffle lines around")

[commit-bot: I haz the power, 2016-03-29 15:52:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1841083002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1841083002/20001

[commit-bot: I haz the power, 2016-03-29 15:55:23]

Description was changed from

==========
Change Windows 10 from SP0 to the build number.

Previous: os=Windows-10-SP0
Now: os=Windows-10-10586

Call sites will need to be updated accordingly.

Next will be to add 'preview' for preview releases.

R=tandrii@chromium.org
BUG=chromium:513354
==========

to

==========
Change Windows 10 from SP0 to the build number.

Previous: os=Windows-10-SP0
Now: os=Windows-10-10586

Call sites will need to be updated accordingly.

Next will be to add 'preview' for preview releases.

R=tandrii@chromium.org
BUG=chromium:513354

Committed:
https://github.com/luci/luci-py/commit/5b9c4a499d51778c4d8061097c1a27fead760f20
==========

[commit-bot: I haz the power, 2016-03-29 15:55:24]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/5b9c4a499d51778c4d8061097c1a27fead760f20

[Will Harris, 2016-03-29 23:02:24]

Hi I noticed the bots were still reporting Windows-10-SP0 e.g.

https://chromium-swarm.appspot.com/restricted/bot/vm1030-m4

I am about to commit some testing code for trybot swarming of some win10 tests
and would like to know if I should specify dimension Windows-10-SP0 or
Windows-10-10240 or Windows-10-10586?

[M-A Ruel, 2016-03-30 12:53:36]

On 2016/03/29 23:02:24, Will Harris wrote:
> Hi I noticed the bots were still reporting Windows-10-SP0 e.g.
> 
> https://chromium-swarm.appspot.com/restricted/bot/vm1030-m4
> 
> I am about to commit some testing code for trybot swarming of some win10 tests
> and would like to know if I should specify dimension Windows-10-SP0 or
> Windows-10-10240 or Windows-10-10586?

I hadn't pushed to prod yet. I just did now.