Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184103030: Plumb changes to the focused frame to WebFramelient. (Closed)

Created:
6 years, 9 months ago by jam
Modified:
6 years, 9 months ago
Reviewers:
dglazkov
CC:
blink-reviews, jamesr, dglazkov+blink, Nate Chapin, gavinp+loader_chromium.org, abarth-chromium, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Plumb changes to the focused frame to WebFrameClient. This is needed so that the browser process can know which frame to send edit commands to. BUG=304341 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168662

Patch Set 1 #

Patch Set 2 : update to send notification to WebFrameClient instead of WebViewClient #

Patch Set 3 : fix crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M Source/core/loader/EmptyClients.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/ChromeClient.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/FocusController.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/ChromeClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M public/web/WebFrameClient.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
jam
6 years, 9 months ago (2014-03-05 01:37:56 UTC) #1
dglazkov
lgtm
6 years, 9 months ago (2014-03-05 04:41:04 UTC) #2
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-05 05:17:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/184103030/1
6 years, 9 months ago (2014-03-05 05:18:29 UTC) #4
jam
The CQ bit was unchecked by jam@chromium.org
6 years, 9 months ago (2014-03-05 16:29:11 UTC) #5
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-05 16:29:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/184103030/1
6 years, 9 months ago (2014-03-05 20:55:44 UTC) #7
jam
The CQ bit was unchecked by jam@chromium.org
6 years, 9 months ago (2014-03-05 21:46:31 UTC) #8
jam
Dmitri: I've updated the patch slightly to move the notification to WebFrameClient instead of WebViewClient, ...
6 years, 9 months ago (2014-03-06 00:43:16 UTC) #9
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-06 17:07:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/184103030/60001
6 years, 9 months ago (2014-03-06 17:08:20 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 17:22:42 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-06 17:22:43 UTC) #13
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-06 17:52:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/184103030/60001
6 years, 9 months ago (2014-03-06 17:52:39 UTC) #15
dglazkov
lgtm++
6 years, 9 months ago (2014-03-06 18:25:39 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 18:32:05 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-06 18:32:05 UTC) #18
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-06 18:37:45 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/184103030/60001
6 years, 9 months ago (2014-03-06 18:37:58 UTC) #20
jam
The CQ bit was unchecked by jam@chromium.org
6 years, 9 months ago (2014-03-06 18:55:37 UTC) #21
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-06 18:55:39 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/184103030/60001
6 years, 9 months ago (2014-03-06 19:02:38 UTC) #23
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 19:25:04 UTC) #24
Message was sent while issue was closed. 
Change committed as 168662

Powered by Google App Engine
This is Rietveld 408576698