Chromium Code Reviews| Index: win_toolchain/toolchain2013.py |
| diff --git a/win_toolchain/toolchain2013.py b/win_toolchain/toolchain2013.py |
| index 0cda5903964931872f52a8f0d4adf0bd39522519..a0d69f2bc649e8c63444baca7579eb362158d092 100755 |
| --- a/win_toolchain/toolchain2013.py |
| +++ b/win_toolchain/toolchain2013.py |
| @@ -196,10 +196,12 @@ def DownloadSDK8(): |
| 'Running sdksetup.exe to download Win8 SDK (may request elevation)...\n') |
| count = 0 |
| while count < 5: |
| - rc = os.system(target_path + ' /quiet ' |
| - '/features OptionId.WindowsDesktopDebuggers ' |
| - 'OptionId.WindowsDesktopSoftwareDevelopmentKit ' |
| - '/layout ' + standalone_path) |
| + # Note: To handle any possible space(s) in sdk_temp_dir, we need to |
| + # *double*-quote the command-line: quote each path and the entire command. |
| + rc = os.system(('""%s" /quiet ' |
|
scottmg
2014/03/05 00:15:37
Thanks for fixing, can you you use
rc = subproc
viettrungluu
2014/03/05 00:39:33
Done. I thought maybe there was a reason you were
|
| + '/features OptionId.WindowsDesktopDebuggers ' |
| + 'OptionId.WindowsDesktopSoftwareDevelopmentKit ' |
| + '/layout "%s""') % (target_path, standalone_path)) |
| if rc == 0: |
| return standalone_path |
| count += 1 |