Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: components/password_manager/core/browser/password_manager_driver.h

Issue 184103016: Autofill: Refactoring to support fetching password after a username is selected (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Actually fix compile failure. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_driver.h
diff --git a/components/password_manager/core/browser/password_manager_driver.h b/components/password_manager/core/browser/password_manager_driver.h
index 3b258400849c52151cded36be5c2d9411ba28289..8087af7a9367aa78460eb6c80ad753bb35c98984 100644
--- a/components/password_manager/core/browser/password_manager_driver.h
+++ b/components/password_manager/core/browser/password_manager_driver.h
@@ -16,6 +16,7 @@ struct PasswordFormFillData;
namespace password_manager {
+class PasswordAutofillManager;
class PasswordGenerationManager;
class PasswordManager;
@@ -37,22 +38,31 @@ class PasswordManagerDriver {
// If this browsing session should not be persisted.
virtual bool IsOffTheRecord() = 0;
+ // Informs the driver that |form| can be used for password generation.
+ virtual void AllowPasswordGenerationForForm(autofill::PasswordForm* form) = 0;
+
+ // Notifies the driver that account creation |forms| were found.
+ virtual void AccountCreationFormsFound(
+ const std::vector<autofill::FormData>& forms) = 0;
+
+ // Tells the driver to accept the password autofill suggestion for |username|
+ // and fill the password with |password|.
+ virtual void AcceptPasswordAutofillSuggestion(
+ const base::string16& username,
+ const base::string16& password) = 0;
+
// Returns the PasswordGenerationManager associated with this instance.
virtual PasswordGenerationManager* GetPasswordGenerationManager() = 0;
// Returns the PasswordManager associated with this instance.
virtual PasswordManager* GetPasswordManager() = 0;
+ // Returns the PasswordAutofillManager associated with this instance.
+ virtual PasswordAutofillManager* GetPasswordAutofillManager() = 0;
+
// Returns the AutofillManager associated with this instance.
virtual autofill::AutofillManager* GetAutofillManager() = 0;
- // Informs the driver that |form| can be used for password generation.
- virtual void AllowPasswordGenerationForForm(autofill::PasswordForm* form) = 0;
-
- // Notifies the driver that account creation |forms| were found.
- virtual void AccountCreationFormsFound(
- const std::vector<autofill::FormData>& forms) = 0;
-
private:
DISALLOW_COPY_AND_ASSIGN(PasswordManagerDriver);
};

Powered by Google App Engine
This is Rietveld 408576698