chrome/browser/ui/tab_helpers.cc - Issue 184103016: Autofill: Refactoring to support fetching password after a username is selected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 184103016: Autofill: Refactoring to support fetching password after a username is selected (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Actually fix compile failure. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client_unittest.cc ('k') | chrome/renderer/autofill/password_autofill_agent_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index 45853cd449987890e79803612c6d898ccce79097..db8b525dbfe2ac8334ac7f0b9de3c9289e32bc3a 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -122,6 +122,9 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

autofill::AutofillManager::ENABLE_AUTOFILL_DOWNLOAD_MANAGER);

BookmarkTabHelper::CreateForWebContents(web_contents);

chrome_browser_net::NetErrorTabHelper::CreateForWebContents(web_contents);

+ ChromePasswordManagerClient::CreateForWebContentsWithAutofillManagerDelegate(

+ web_contents,

+ autofill::TabAutofillManagerDelegate::FromWebContents(web_contents));

CoreTabHelper::CreateForWebContents(web_contents);

extensions::TabHelper::CreateForWebContents(web_contents);

FaviconTabHelper::CreateForWebContents(web_contents);

@@ -130,7 +133,6 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

InfoBarService::CreateForWebContents(web_contents);

NavigationCorrectionTabObserver::CreateForWebContents(web_contents);

NavigationMetricsRecorder::CreateForWebContents(web_contents);

- ChromePasswordManagerClient::CreateForWebContents(web_contents);

PopupBlockerTabHelper::CreateForWebContents(web_contents);

PrefsTabHelper::CreateForWebContents(web_contents);

prerender::PrerenderTabHelper::CreateForWebContentsWithPasswordManager(