components/password_manager/core/browser/password_manager.cc - Issue 184103016: Autofill: Refactoring to support fetching password after a username is selected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 184103016: Autofill: Refactoring to support fetching password after a username is selected (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_autofill_manager.h ('K') | « components/password_manager/core/browser/password_generation_manager_unittest.cc ('k') | components/password_manager/core/browser/password_manager_driver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index 107ce1e8bed13772209c7acd4296619f58ebea77..5947e32243b26eaa5fd3b1c1a1a0f23b4a762e91 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -12,6 +12,7 @@

#include "base/strings/utf_string_conversions.h"

#include "base/threading/platform_thread.h"

#include "components/autofill/core/common/password_autofill_util.h"

+#include "components/password_manager/core/browser/password_autofill_manager.h"

#include "components/password_manager/core/browser/password_form_manager.h"

#include "components/password_manager/core/browser/password_manager_client.h"

#include "components/password_manager/core/browser/password_manager_driver.h"

@@ -226,8 +227,10 @@ void PasswordManager::RemoveObserver(LoginModelObserver* observer) {

void PasswordManager::DidNavigateMainFrame(bool is_in_page) {

// Clear data after main frame navigation if the navigation was to a

// different page.

- if (!is_in_page)

+ if (!is_in_page) {

pending_login_managers_.clear();

+ driver_->GetPasswordAutofillManager()->Reset();

+ }

}

void PasswordManager::OnPasswordFormSubmitted(