Autofill: Refactoring to support fetching password after a username is selected

components/autofill/content/renderer/password_autofill_agent.h

Index: components/autofill/content/renderer/password_autofill_agent.h
diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h
index 17ae4831fe58a5aec23fe2598aa329f18ea330f7..a712fa93a7538a0d34b0b2fddf1b38bf89bab6c3 100644
--- a/components/autofill/content/renderer/password_autofill_agent.h
+++ b/components/autofill/content/renderer/password_autofill_agent.h
@@ -38,10 +38,12 @@ class PasswordAutofillAgent : public content::RenderViewObserver {
   bool TextFieldHandlingKeyDown(const blink::WebInputElement& element,
                                 const blink::WebKeyboardEvent& event);
 
-  // Fills the password associated with user name |username|. Returns true if
-  // the username and password fields were filled, false otherwise.
-  bool DidAcceptAutofillSuggestion(const blink::WebNode& node,
-                                   const blink::WebString& username);
+  // Fills the username and password fields of this form with the given values.
+  // Returns true if the fields were filled, false otherwise.

[Ilya Sherman, 2014/03/28 21:33:34]

This doesn't match what the implementation currently does.  Specifically, the
method returns true but the fields remain unfilled if either element is
unfillable.

[Patrick Dubroy, 2014/04/01 16:08:48]

Fixed (the implementation, not the comment).

+  bool AcceptAutofillSuggestion(const blink::WebNode& node,
+                                const blink::WebString& username,
+                                const blink::WebString& password);
+
   // A no-op.  Password forms are not previewed, so they do not need to be
   // cleared when the selection changes.  However, this method returns
   // true when |node| is fillable by password Autofill.