components/password_manager/core/browser/password_manager_unittest.cc - Issue 184103016: Autofill: Refactoring to support fetching password after a username is selected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 184103016: Autofill: Refactoring to support fetching password after a username is selected (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address gcasto's comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_manager.h ('K') | « components/password_manager/core/browser/password_manager_driver.h ('k') | components/password_manager/core/browser/test_password_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc

index 44a5f39e2b82191bd212f02f2f787ddf48252443..6c0ec18a07197443dd4ea2f8ce8a300bec8c61c5 100644

--- a/components/password_manager/core/browser/password_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_manager_unittest.cc

@@ -66,6 +66,9 @@ class MockPasswordManagerDriver : public PasswordManagerDriver {

MOCK_METHOD1(AllowPasswordGenerationForForm, void(autofill::PasswordForm*));

MOCK_METHOD1(AccountCreationFormsFound,

void(const std::vector<autofill::FormData>&));

+ MOCK_METHOD2(AcceptPasswordAutofillSuggestion,

+ void(const base::string16&, const base::string16&));

+ MOCK_METHOD0(GetPasswordAutofillManager, PasswordAutofillManager*());

Ilya Sherman 2014/03/18 00:14:27 nit: Unneeded?

Patrick Dubroy 2014/03/28 15:44:22 Yes, pure virtuals. Will fix in a future CL as men

};

ACTION_P(InvokeConsumer, forms) { arg0->OnGetPasswordStoreResults(forms); }