Autofill: Refactoring to support fetching password after a username is selected

components/autofill/content/renderer/password_autofill_agent.cc

Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index df8056242e3eed16495550ae170eeafec6200860..d20f5124c912030233be573c688dcbe3ed657d36 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -351,21 +351,22 @@ bool PasswordAutofillAgent::TextFieldHandlingKeyDown(
   return true;
 }
 
-bool PasswordAutofillAgent::DidAcceptAutofillSuggestion(
+bool PasswordAutofillAgent::AcceptAutofillSuggestionWithPassword(
     const blink::WebNode& node,
-    const blink::WebString& username) {
-  blink::WebInputElement input;
-  PasswordInfo password;
-  if (!FindLoginInfo(node, &input, &password))
+    const blink::WebString& username,
+    const blink::WebString& password) {
+  blink::WebInputElement username_element;
+  PasswordInfo password_info;
+  if (!FindLoginInfo(node, &username_element, &password_info))
     return false;
 
-  // Set the incoming |username| in the text field and |FillUserNameAndPassword|
-  // will do the rest.
-  input.setValue(username, true);
-  return FillUserNameAndPassword(&input, &password.password_field,
-                                 password.fill_data,
-                                 true /* exact_username_match */,
-                                 true /* set_selection */);
+  username_element.setValue(username, true);
+  SetElementAutofilled(&username_element, true);

[Ilya Sherman, 2014/03/18 00:14:27]

Hmm, this is missing IsElementAutocompletable() checks, and fails to set the
selection for the username field.  Are these intentional changes in behavior?

[Patrick Dubroy, 2014/03/28 15:44:22]

No, that was an oversight. Fixed.

+
+  password_info.password_field.setValue(password, true);
+  SetElementAutofilled(&password_info.password_field, true);
+
+  return true;
 }
 
 bool PasswordAutofillAgent::DidClearAutofillSelection(