Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: components/autofill/core/browser/password_autofill_manager.h

Issue 184103016: Autofill: Refactoring to support fetching password after a username is selected (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/password_autofill_manager.h
diff --git a/components/autofill/core/browser/password_autofill_manager.h b/components/autofill/core/browser/password_autofill_manager.h
index ddde78eb0faa337f9a1ef49f98af8daca681e231..2c3211290ce590e17a69b15788b50002763dbae9 100644
--- a/components/autofill/core/browser/password_autofill_manager.h
+++ b/components/autofill/core/browser/password_autofill_manager.h
@@ -15,6 +15,7 @@
#include <map>
#include "components/autofill/core/common/password_form_fill_data.h"
+#include "components/password_manager/core/browser/password_manager_driver.h"
namespace autofill {
@@ -23,7 +24,7 @@ class AutofillDriver;
// This class is responsible for filling password forms.
class PasswordAutofillManager {
public:
- explicit PasswordAutofillManager(AutofillDriver* autofill_driver);
+ explicit PasswordAutofillManager(PasswordManagerDriver* driver);
virtual ~PasswordAutofillManager();
// Fills the password associated with user name |username|. Returns true if
@@ -49,9 +50,10 @@ class PasswordAutofillManager {
// Returns true if |current_username| matches a username for one of the
// login mappings in |password|.
- bool WillFillUserNameAndPassword(
+ bool GetPasswordForUsername(
const base::string16& current_username,
- const PasswordFormFillData& password);
+ const PasswordFormFillData& fill_data,
+ base::string16* password);
// Finds login information for a |node| that was previously filled.
bool FindLoginInfo(const FormFieldData& field,
@@ -62,7 +64,7 @@ class PasswordAutofillManager {
// Provides driver-level context to the shared code of the component. Must
// outlive |this|.
- AutofillDriver* const autofill_driver_; // weak
+ PasswordManagerDriver* const driver_; // weak
DISALLOW_COPY_AND_ASSIGN(PasswordAutofillManager);
};

Powered by Google App Engine
This is Rietveld 408576698