Autofill: Refactoring to support fetching password after a username is selected

components/password_manager/core/browser/password_autofill_manager.cc

Index: components/password_manager/core/browser/password_autofill_manager.cc
diff --git a/components/password_manager/core/browser/password_autofill_manager.cc b/components/password_manager/core/browser/password_autofill_manager.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7335bed0e5819824873085e814dacba496e5292c
--- /dev/null
+++ b/components/password_manager/core/browser/password_autofill_manager.cc
@@ -0,0 +1,165 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/logging.h"
+#include "components/autofill/core/browser/autofill_driver.h"
+#include "components/autofill/core/browser/popup_item_ids.h"
+#include "components/password_manager/core/browser/password_autofill_manager.h"
+#include "components/password_manager/core/browser/password_manager_client.h"
+#include "components/password_manager/core/browser/password_manager_driver.h"
+
+////////////////////////////////////////////////////////////////////////////////
+// PasswordAutofillManager, public:
+
+PasswordAutofillManager::PasswordAutofillManager(
+    PasswordManagerClient* password_manager_client,
+    autofill::AutofillManagerDelegate* autofill_manager_delegate)
+    : password_manager_client_(password_manager_client),
+      autofill_manager_delegate_(autofill_manager_delegate),
+      weak_ptr_factory_(this) {
+}
+
+PasswordAutofillManager::~PasswordAutofillManager() {
+}
+
+bool PasswordAutofillManager::AcceptAutofillSuggestion(
+    const autofill::FormFieldData& field,
+    const base::string16& username) {
+  autofill::PasswordFormFillData fill_data;
+  base::string16 password;
+  if (FindLoginInfo(field, &fill_data) &&
+      GetPasswordForUsername(username, fill_data, &password)) {
+    PasswordManagerDriver* driver = password_manager_client_->GetDriver();
+    driver->AcceptPasswordAutofillSuggestion(username, password);
+    return true;
+  }
+  return false;
+}
+
+void PasswordAutofillManager::AddPasswordFormMapping(
+    const autofill::FormFieldData& username_element,
+    const autofill::PasswordFormFillData& password) {
+  login_to_password_info_[username_element] = password;
+}
+
+void PasswordAutofillManager::ShowPasswordSuggestions(
+    const autofill::FormFieldData& field,
+    const gfx::RectF& bounds,
+    const std::vector<base::string16>& suggestions,
+    const std::vector<base::string16>& realms) {
+  form_field_ = field;
+
+  if (suggestions.empty()) {
+    autofill_manager_delegate_->HideAutofillPopup();
+    return;
+  }
+
+  std::vector<base::string16> empty(suggestions.size());
+  std::vector<int> password_ids(suggestions.size(),
+                                autofill::POPUP_ITEM_ID_PASSWORD_ENTRY);
+  autofill_manager_delegate_->ShowAutofillPopup(
+      bounds,
+      field.text_direction,
+      suggestions,
+      realms,
+      empty,
+      password_ids,
+      weak_ptr_factory_.GetWeakPtr());
+}
+
+void PasswordAutofillManager::Reset() {
+  login_to_password_info_.clear();
+}
+
+void PasswordAutofillManager::OnPopupShown() {
+  /* FIXME: Do we need this? It's only used for metrics logging.

[Garrett Casto, 2014/03/14 08:25:22]

Having some logging here might eventually be interesting, but we certainly don't
need it now.

[Patrick Dubroy, 2014/03/14 12:07:19]

Done.

+  manager_->DidShowSuggestions(
+      has_suggestion_ && !has_shown_popup_for_current_edit_);
+  has_shown_popup_for_current_edit_ |= has_suggestion_;
+  */
+}
+
+void PasswordAutofillManager::OnPopupHidden() {
+}
+
+bool PasswordAutofillManager::ShouldRepostEvent(const ui::MouseEvent& event) {
+  // FIXME: Can we get rid of this?

[Garrett Casto, 2014/03/14 08:25:22]

If you mean this interface function, I don't think so. It's used by
AutofillPopupControllerImpl.

[Patrick Dubroy, 2014/03/14 12:07:19]

Ah, I see. That's kind of unfortunate, but what can you do.

+  NOTREACHED();
+  return true;
+}
+
+void PasswordAutofillManager::DidSelectSuggestion(int identifier) {
+  // This is called to preview an autofill suggestion, but we don't currently
+  // do that for password forms.
+}
+
+void PasswordAutofillManager::DidAcceptSuggestion(const base::string16& value,
+                                                  int identifier) {
+  if (!AcceptAutofillSuggestion(form_field_, value))
+    NOTREACHED();
+  autofill_manager_delegate_->HideAutofillPopup();
+}
+
+void PasswordAutofillManager::RemoveSuggestion(const base::string16& value,
+                                               int identifier) {
+  NOTREACHED();
+}
+
+void PasswordAutofillManager::ClearPreviewedForm() {
+  NOTREACHED();
+  //  driver_->RendererShouldClearPreviewedForm(); // FIXME: Do we need this?

[Garrett Casto, 2014/03/14 08:25:22]

No, password autofill doesn't preview at the moment. There is a longstanding bug
for this (crbug.com/63421).

[Patrick Dubroy, 2014/03/14 12:07:19]

Done.

+}
+
+////////////////////////////////////////////////////////////////////////////////
+// PasswordAutofillManager, private:
+
+bool PasswordAutofillManager::GetPasswordForUsername(
+    const base::string16& current_username,
+    const autofill::PasswordFormFillData& fill_data,
+    base::string16* password) {
+  // TODO(dubroy): When password access requires some kind of authentication
+  // (e.g. Keychain access on Mac OS), use |password_manager_client_| here to
+  // fetch the actual password. See crbug.com/178358 for more context.
+
+  // Look for any suitable matches to current field text.
+  if (fill_data.basic_data.fields[0].value == current_username) {
+    *password = fill_data.basic_data.fields[1].value;
+    return true;
+  }
+
+  // Scan additional logins for a match.
+   for (autofill::PasswordFormFillData::LoginCollection::const_iterator iter =
+           fill_data.additional_logins.begin();
+       iter != fill_data.additional_logins.end(); ++iter) {
+     if (iter->first == current_username) {
+       *password = iter->second.password;
+       return true;
+     }
+  }
+
+  for (autofill::PasswordFormFillData::UsernamesCollection::const_iterator
+           usernames_iter = fill_data.other_possible_usernames.begin();
+       usernames_iter != fill_data.other_possible_usernames.end();
+       ++usernames_iter) {
+    for (size_t i = 0; i < usernames_iter->second.size(); ++i) {
+      if (usernames_iter->second[i] == current_username) {
+        *password = usernames_iter->first.password;
+        return true;
+      }
+    }
+  }
+
+  return false;
+}
+
+bool PasswordAutofillManager::FindLoginInfo(
+    const autofill::FormFieldData& field,
+    autofill::PasswordFormFillData* found_password) {
+  LoginToPasswordInfoMap::iterator iter = login_to_password_info_.find(field);
+  if (iter == login_to_password_info_.end())
+    return false;
+
+  *found_password = iter->second;
+  return true;
+}