Autofill: Refactoring to support fetching password after a username is selected

components/autofill/core/browser/autofill_external_delegate.cc

Index: components/autofill/core/browser/autofill_external_delegate.cc
diff --git a/components/autofill/core/browser/autofill_external_delegate.cc b/components/autofill/core/browser/autofill_external_delegate.cc
index bd3795c41d2f16775a6cd9a71ff5780159b07c8d..c283b9b7f6e59fc1b2ec7dc2fe9385a2053ddf14 100644
--- a/components/autofill/core/browser/autofill_external_delegate.cc
+++ b/components/autofill/core/browser/autofill_external_delegate.cc
@@ -19,7 +19,6 @@ AutofillExternalDelegate::AutofillExternalDelegate(
     AutofillDriver* driver)
     : manager_(manager),
       driver_(driver),
-      password_manager_(driver),
       query_id_(0),
       display_warning_if_disabled_(false),
       has_suggestion_(false),
@@ -111,32 +110,6 @@ void AutofillExternalDelegate::OnSuggestionsReturned(
   }
 }
 
-void AutofillExternalDelegate::OnShowPasswordSuggestions(
-    const std::vector<base::string16>& suggestions,
-    const std::vector<base::string16>& realms,
-    const FormFieldData& field,
-    const gfx::RectF& element_bounds) {
-  query_field_ = field;
-  element_bounds_ = element_bounds;
-
-  if (suggestions.empty()) {
-    manager_->delegate()->HideAutofillPopup();
-    return;
-  }
-
-  std::vector<base::string16> empty(suggestions.size());
-  std::vector<int> password_ids(suggestions.size(),
-                                POPUP_ITEM_ID_PASSWORD_ENTRY);
-  manager_->delegate()->ShowAutofillPopup(
-      element_bounds_,
-      query_field_.text_direction,
-      suggestions,
-      realms,
-      empty,
-      password_ids,
-      GetWeakPtr());
-}
-
 void AutofillExternalDelegate::SetCurrentDataListValues(
     const std::vector<base::string16>& data_list_values,
     const std::vector<base::string16>& data_list_labels) {
@@ -179,9 +152,7 @@ void AutofillExternalDelegate::DidAcceptSuggestion(const base::string16& value,
     // User selected 'Clear form'.
     driver_->RendererShouldClearFilledForm();
   } else if (identifier == POPUP_ITEM_ID_PASSWORD_ENTRY) {

[Garrett Casto, 2014/03/14 08:25:22]

Seems like eventually this should be removed, but I'm fine leaving it for extra
verification for now.

-    bool success = password_manager_.DidAcceptAutofillSuggestion(
-        query_field_, value);
-    DCHECK(success);
+    NOTREACHED();  // Should be handled elsewhere.
   } else if (identifier == POPUP_ITEM_ID_DATALIST_ENTRY) {
     driver_->RendererShouldAcceptDataListSuggestion(value);
   } else if (identifier == POPUP_ITEM_ID_AUTOCOMPLETE_ENTRY) {
@@ -214,14 +185,6 @@ void AutofillExternalDelegate::ClearPreviewedForm() {
 
 void AutofillExternalDelegate::Reset() {
   manager_->delegate()->HideAutofillPopup();
-
-  password_manager_.Reset();
-}
-
-void AutofillExternalDelegate::AddPasswordFormMapping(
-      const FormFieldData& username_field,
-      const PasswordFormFillData& fill_data) {
-  password_manager_.AddPasswordFormMapping(username_field, fill_data);
 }
 
 base::WeakPtr<AutofillExternalDelegate> AutofillExternalDelegate::GetWeakPtr() {