Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 184103016: Autofill: Refactoring to support fetching password after a username is selected (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Actually fix compile failure. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/chrome_password_manager_client.h" 5 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
6 6
7 #include "chrome/test/base/chrome_render_view_host_test_harness.h" 7 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
8 #include "components/password_manager/core/browser/password_manager_logger.h" 8 #include "components/password_manager/core/browser/password_manager_logger.h"
9 #include "content/public/browser/browser_context.h" 9 #include "content/public/browser/browser_context.h"
10 #include "content/public/browser/web_contents.h" 10 #include "content/public/browser/web_contents.h"
(...skipping 22 matching lines...) Expand all
33 virtual void SetUp() OVERRIDE; 33 virtual void SetUp() OVERRIDE;
34 34
35 protected: 35 protected:
36 ChromePasswordManagerClient* GetClient(); 36 ChromePasswordManagerClient* GetClient();
37 37
38 testing::StrictMock<MockPasswordManagerLogger> logger; 38 testing::StrictMock<MockPasswordManagerLogger> logger;
39 }; 39 };
40 40
41 void ChromePasswordManagerClientTest::SetUp() { 41 void ChromePasswordManagerClientTest::SetUp() {
42 ChromeRenderViewHostTestHarness::SetUp(); 42 ChromeRenderViewHostTestHarness::SetUp();
43 ChromePasswordManagerClient::CreateForWebContents(web_contents()); 43 ChromePasswordManagerClient::CreateForWebContentsWithAutofillManagerDelegate(
44 web_contents(), NULL);
44 } 45 }
45 46
46 ChromePasswordManagerClient* ChromePasswordManagerClientTest::GetClient() { 47 ChromePasswordManagerClient* ChromePasswordManagerClientTest::GetClient() {
47 return ChromePasswordManagerClient::FromWebContents(web_contents()); 48 return ChromePasswordManagerClient::FromWebContents(web_contents());
48 } 49 }
49 50
50 TEST_F(ChromePasswordManagerClientTest, LogSavePasswordProgressNoLogger) { 51 TEST_F(ChromePasswordManagerClientTest, LogSavePasswordProgressNoLogger) {
51 ChromePasswordManagerClient* client = GetClient(); 52 ChromePasswordManagerClient* client = GetClient();
52 53
53 EXPECT_CALL(logger, LogSavePasswordProgress(kTestText)).Times(0); 54 EXPECT_CALL(logger, LogSavePasswordProgress(kTestText)).Times(0);
(...skipping 15 matching lines...) Expand all
69 TEST_F(ChromePasswordManagerClientTest, LogSavePasswordProgressDetachLogger) { 70 TEST_F(ChromePasswordManagerClientTest, LogSavePasswordProgressDetachLogger) {
70 ChromePasswordManagerClient* client = GetClient(); 71 ChromePasswordManagerClient* client = GetClient();
71 72
72 client->SetLogger(&logger); 73 client->SetLogger(&logger);
73 // After detaching the logger, no text should be passed. 74 // After detaching the logger, no text should be passed.
74 client->SetLogger(NULL); 75 client->SetLogger(NULL);
75 EXPECT_CALL(logger, LogSavePasswordProgress(kTestText)).Times(0); 76 EXPECT_CALL(logger, LogSavePasswordProgress(kTestText)).Times(0);
76 client->LogSavePasswordProgress(kTestText); 77 client->LogSavePasswordProgress(kTestText);
77 EXPECT_FALSE(client->IsLoggingActive()); 78 EXPECT_FALSE(client->IsLoggingActive());
78 } 79 }
OLDNEW
« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698