Autofill: Refactoring to support fetching password after a username is selected

components/autofill/content/renderer/password_autofill_agent.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
 
 #include <map>
 #include <vector>
 
@@ skipping 21 matching lines @@
 
   // WebViewClient editor related calls forwarded by the RenderView.
   // If they return true, it indicates the event was consumed and should not
   // be used for any other autofill activity.
   bool TextFieldDidEndEditing(const blink::WebInputElement& element);
   bool TextDidChangeInTextField(const blink::WebInputElement& element);
   bool TextFieldHandlingKeyDown(const blink::WebInputElement& element,
                                 const blink::WebKeyboardEvent& event);
 
   // Fills the password associated with user name |username|. Returns true if
   // the username and password fields were filled, false otherwise.

[Ilya Sherman, 2014/03/18 00:14:27]

nit: Please update this comment.

[Patrick Dubroy, 2014/03/28 15:44:22]

Done.

-  bool DidAcceptAutofillSuggestion(const blink::WebNode& node,
-                                   const blink::WebString& username);
+  bool AcceptAutofillSuggestionWithPassword(const blink::WebNode& node,

[Ilya Sherman, 2014/03/18 00:14:27]

Optional nit: I'd shorten this name to just "AcceptSuggestion", but the longer
name is fine too if you prefer it.

[Patrick Dubroy, 2014/03/28 15:44:22]

I shortened to just AcceptAutofillSuggestion, if that's ok. Otherwise I think
AcceptSuggestion, in the context of passwords, is ambiguous -- it could mean an
autofill suggestion, or it could mean a generated password. At least, Vaclav and
I both felt it could be confusing.

[Ilya Sherman, 2014/03/28 21:33:34]

Since this class is the password *autofill* agent, I honestly don't think it's
especially helpful to include "Autofill" in method names -- especially since
this class doesn't actually deal with generated password suggestions and since
there's a method named "ShowSuggestions()" below.  But, this also isn't cleanup
that needs to happen as part of this CL, especially if you and Vaclav both think
it provides some clarity.

[Patrick Dubroy, 2014/04/01 16:08:48]

Ok, I agree. Changed. (In fairness, Vaclav didn't really have the full context
when I asked him the question.)

+                                            const blink::WebString& username,
+                                            const blink::WebString& password);
+
   // A no-op.  Password forms are not previewed, so they do not need to be
   // cleared when the selection changes.  However, this method returns
   // true when |node| is fillable by password Autofill.
   bool DidClearAutofillSelection(const blink::WebNode& node);
   // Shows an Autofill popup with username suggestions for |element|.
   // Returns true if any suggestions were shown, false otherwise.
   bool ShowSuggestions(const blink::WebInputElement& element);
 
   // Called when new form controls are inserted.
   void OnDynamicFormsSeen(blink::WebFrame* frame);
@@ skipping 135 matching lines @@
   PasswordValueGatekeeper gatekeeper_;
 
   base::WeakPtrFactory<PasswordAutofillAgent> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgent);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_