Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: components/autofill/core/browser/autofill_manager.h

Issue 184103016: Autofill: Refactoring to support fetching password after a username is selected (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Refactor PasswordAutofillManager in password_manager component. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 const base::TimeTicks& timestamp); 132 const base::TimeTicks& timestamp);
133 133
134 // The |bounding_box| is a window relative value. 134 // The |bounding_box| is a window relative value.
135 void OnQueryFormFieldAutofill(int query_id, 135 void OnQueryFormFieldAutofill(int query_id,
136 const FormData& form, 136 const FormData& form,
137 const FormFieldData& field, 137 const FormFieldData& field,
138 const gfx::RectF& bounding_box, 138 const gfx::RectF& bounding_box,
139 bool display_warning); 139 bool display_warning);
140 void OnDidEndTextFieldEditing(); 140 void OnDidEndTextFieldEditing();
141 void OnHidePopup(); 141 void OnHidePopup();
142 void OnAddPasswordFormMapping(
143 const FormFieldData& username_field,
144 const PasswordFormFillData& fill_data);
145 void OnShowPasswordSuggestions(
146 const FormFieldData& field,
147 const gfx::RectF& bounds,
148 const std::vector<base::string16>& suggestions,
149 const std::vector<base::string16>& realms);
150 void OnSetDataList(const std::vector<base::string16>& values, 142 void OnSetDataList(const std::vector<base::string16>& values,
151 const std::vector<base::string16>& labels); 143 const std::vector<base::string16>& labels);
152 144
153 // Try and upload |form|. This differs from OnFormSubmitted() in a few ways. 145 // Try and upload |form|. This differs from OnFormSubmitted() in a few ways.
154 // - This function will only label the first <input type="password"> field 146 // - This function will only label the first <input type="password"> field
155 // as ACCOUNT_CREATION_PASSWORD. Other fields will stay unlabeled, as they 147 // as ACCOUNT_CREATION_PASSWORD. Other fields will stay unlabeled, as they
156 // should have been labeled during the upload for OnFormSubmitted(). 148 // should have been labeled during the upload for OnFormSubmitted().
157 // - This function does not assume that |form| is being uploaded during 149 // - This function does not assume that |form| is being uploaded during
158 // the same browsing session as it was originally submitted (as we may 150 // the same browsing session as it was originally submitted (as we may
159 // not have the necessary information to classify the form at that time) 151 // not have the necessary information to classify the form at that time)
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 UserHappinessFormLoadAndSubmission); 358 UserHappinessFormLoadAndSubmission);
367 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction); 359 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
368 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 360 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
369 FormSubmittedAutocompleteEnabled); 361 FormSubmittedAutocompleteEnabled);
370 DISALLOW_COPY_AND_ASSIGN(AutofillManager); 362 DISALLOW_COPY_AND_ASSIGN(AutofillManager);
371 }; 363 };
372 364
373 } // namespace autofill 365 } // namespace autofill
374 366
375 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 367 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698