Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184103012: Oilpan: ~StyleSheetContents should not touch its Member<> (Closed)

Created:
6 years, 9 months ago by kouhei (in TOK)
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Oilpan: ~StyleSheetContents should not touch its Member<> BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168345

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/css/StyleSheetContents.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
kouhei (in TOK)
6 years, 9 months ago (2014-03-03 08:02:23 UTC) #1
kouhei (in TOK)
6 years, 9 months ago (2014-03-03 08:02:23 UTC) #2
haraken
LGTM
6 years, 9 months ago (2014-03-03 08:11:15 UTC) #3
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-03 08:13:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/184103012/20001
6 years, 9 months ago (2014-03-03 08:13:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 11:41:20 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24420
6 years, 9 months ago (2014-03-03 11:41:21 UTC) #7
Vyacheslav Egorov (Chromium)
LGTM, thanks for fixing it.
6 years, 9 months ago (2014-03-03 11:49:51 UTC) #8
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-03 12:38:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/184103012/20001
6 years, 9 months ago (2014-03-03 12:38:10 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 15:22:37 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24558
6 years, 9 months ago (2014-03-03 15:22:37 UTC) #12
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-04 00:40:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/184103012/20001
6 years, 9 months ago (2014-03-04 00:40:24 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 00:41:11 UTC) #15
Message was sent while issue was closed. 
Change committed as 168345

Powered by Google App Engine
This is Rietveld 408576698