Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1841013003: Update GN documentation. (Closed)

Created:
4 years, 8 months ago by brettw
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update GN documentation. This mostly updates the language.md file. Committed: https://crrev.com/42998ec24cfcc5ced964448e77bc43bbdeca35dd Cr-Commit-Position: refs/heads/master@{#383876}

Patch Set 1 #

Total comments: 3

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -92 lines) Patch
M tools/gn/command_help.cc View 1 chunk +14 lines, -1 line 0 comments Download
M tools/gn/docs/language.md View 1 19 chunks +129 lines, -54 lines 0 comments Download
M tools/gn/docs/reference.md View 2 chunks +21 lines, -1 line 0 comments Download
M tools/gn/docs/style_guide.md View 2 chunks +25 lines, -35 lines 0 comments Download
M tools/gn/function_foreach.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
brettw
4 years, 8 months ago (2016-03-29 21:17:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841013003/1
4 years, 8 months ago (2016-03-29 21:17:56 UTC) #4
Dirk Pranke
lgtm w/ nits. https://codereview.chromium.org/1841013003/diff/1/tools/gn/docs/language.md File tools/gn/docs/language.md (right): https://codereview.chromium.org/1841013003/diff/1/tools/gn/docs/language.md#newcode133 tools/gn/docs/language.md:133: dependency appear once. This is the ...
4 years, 8 months ago (2016-03-29 21:27:46 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 21:59:58 UTC) #7
brettw
.
4 years, 8 months ago (2016-03-29 23:41:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841013003/20001
4 years, 8 months ago (2016-03-29 23:41:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 00:22:51 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 00:23:59 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/42998ec24cfcc5ced964448e77bc43bbdeca35dd
Cr-Commit-Position: refs/heads/master@{#383876}

Powered by Google App Engine
This is Rietveld 408576698