Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1840963002: Port refcount-leaks to PPAPI (Closed)

Created:
4 years, 8 months ago by piman
Modified:
4 years, 8 months ago
Reviewers:
dcheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port refcount-leaks to PPAPI Trying to keep the spirit of the test, but refcount is not exposed to the plugin in PPAPI, so just focus on the instance count. BUG=318978, 493212, 474535 Committed: https://crrev.com/ef6f7853d2fe2da55cf97718135d572a42aa841d Cr-Commit-Position: refs/heads/master@{#383677}

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -41 lines) Patch
M ppapi/tests/blink_deprecated_test_plugin.cc View 8 chunks +34 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/plugins/refcount-leaks.html View 1 3 chunks +47 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/plugins/refcount-leaks-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
piman
4 years, 8 months ago (2016-03-29 03:05:59 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840963002/20001
4 years, 8 months ago (2016-03-29 03:06:34 UTC) #6
dcheng
lgtm https://codereview.chromium.org/1840963002/diff/20001/third_party/WebKit/LayoutTests/plugins/refcount-leaks.html File third_party/WebKit/LayoutTests/plugins/refcount-leaks.html (right): https://codereview.chromium.org/1840963002/diff/20001/third_party/WebKit/LayoutTests/plugins/refcount-leaks.html#newcode45 third_party/WebKit/LayoutTests/plugins/refcount-leaks.html:45: No test expectations here because we can't get ...
4 years, 8 months ago (2016-03-29 03:15:24 UTC) #7
piman
https://codereview.chromium.org/1840963002/diff/20001/third_party/WebKit/LayoutTests/plugins/refcount-leaks.html File third_party/WebKit/LayoutTests/plugins/refcount-leaks.html (right): https://codereview.chromium.org/1840963002/diff/20001/third_party/WebKit/LayoutTests/plugins/refcount-leaks.html#newcode45 third_party/WebKit/LayoutTests/plugins/refcount-leaks.html:45: On 2016/03/29 03:15:24, dcheng wrote: > No test expectations ...
4 years, 8 months ago (2016-03-29 05:09:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840963002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840963002/40001
4 years, 8 months ago (2016-03-29 05:13:35 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-03-29 06:11:50 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 06:13:02 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef6f7853d2fe2da55cf97718135d572a42aa841d
Cr-Commit-Position: refs/heads/master@{#383677}

Powered by Google App Engine
This is Rietveld 408576698