telemetry/telemetry/internal/platform/win_platform_backend.py - Issue 1840893003: [Telemetry] Uses OSError instead of WindowsError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/win_platform_backend.py

Issue 1840893003: [Telemetry] Uses OSError instead of WindowsError (Closed) Base URL: https://github.com/catapult-project/catapult@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/internal/platform/win_platform_backend.py

diff --git a/telemetry/telemetry/internal/platform/win_platform_backend.py b/telemetry/telemetry/internal/platform/win_platform_backend.py

index 2cdf32b2da9562e497c20ffa76d0786ffb888e9e..3ae2a21f748cc28d9b814693b9c08f01bc7b1df1 100644

--- a/telemetry/telemetry/internal/platform/win_platform_backend.py

+++ b/telemetry/telemetry/internal/platform/win_platform_backend.py

@@ -250,7 +250,7 @@ class WinPlatformBackend(desktop_platform_backend.DesktopPlatformBackend):

key = winreg.OpenKey(winreg.HKEY_LOCAL_MACHINE, key_name)

try:

value, _ = winreg.QueryValueEx(key, 'CurrentMajorVersionNumber')

- except WindowsErrror: # pylint: disable=undefined-variable

+ except OSError:

value = None

finally:

key.Close()

« no previous file with comments | « no previous file | no next file » | no next file with comments »