Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1840873002: Enable symbols with ASan (Closed)

Created:
4 years, 8 months ago by Reid Kleckner
Modified:
4 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable symbols with ASan This sets -gline-tables-only to try to keep linking fast. This is consistent with other platforms, which do the same for DWARF. R=thakis@chromium.org BUG=598344 Committed: https://crrev.com/a9fefb873b684ccd3732a8859c3c8daa7635da2e Cr-Commit-Position: refs/heads/master@{#383659}

Patch Set 1 #

Patch Set 2 : Try to write some gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M build/common.gypi View 2 chunks +3 lines, -2 lines 0 comments Download
M build/config/compiler/compiler.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M build/config/sanitizers/BUILD.gn View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Reid Kleckner
4 years, 8 months ago (2016-03-28 23:25:37 UTC) #1
Nico
On 2016/03/28 23:25:37, Reid Kleckner wrote: Needs gn change too
4 years, 8 months ago (2016-03-28 23:27:02 UTC) #2
Reid Kleckner
Try to write some gn
4 years, 8 months ago (2016-03-28 23:41:13 UTC) #3
Reid Kleckner
On 2016/03/28 23:41:13, Reid Kleckner wrote: > Try to write some gn Hah, so I ...
4 years, 8 months ago (2016-03-28 23:55:49 UTC) #4
Nico
On 2016/03/28 23:55:49, Reid Kleckner wrote: > On 2016/03/28 23:41:13, Reid Kleckner wrote: > > ...
4 years, 8 months ago (2016-03-29 01:11:39 UTC) #5
Reid Kleckner
On 2016/03/29 01:11:39, Nico wrote: > Oh hm :-/ I guess lgtm then, but maybe ...
4 years, 8 months ago (2016-03-29 01:28:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840873002/20001
4 years, 8 months ago (2016-03-29 01:28:52 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 02:41:11 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 02:42:33 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a9fefb873b684ccd3732a8859c3c8daa7635da2e
Cr-Commit-Position: refs/heads/master@{#383659}

Powered by Google App Engine
This is Rietveld 408576698