Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: blimp/common/logging.cc

Issue 1840843005: blimp: Add logging for compositor and render widget feature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missed a test. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/feature/compositor/blimp_compositor_manager.cc ('k') | blimp/common/logging_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/common/logging.cc
diff --git a/blimp/common/logging.cc b/blimp/common/logging.cc
index 37aa51348e17763f84a9e3fc7e58692d59bdbee7..c115f56db6315557901a882e83904b3b981aca02 100644
--- a/blimp/common/logging.cc
+++ b/blimp/common/logging.cc
@@ -133,6 +133,23 @@ class NavigationLogExtractor : public LogExtractor {
}
};
+// Logs fields from COMPOSITOR messages.
+class CompositorLogExtractor : public LogExtractor {
+ void ExtractFields(const BlimpMessage& message,
+ LogFields* output) const override {
+ AddField("render_widget_id", message.compositor().render_widget_id(),
+ output);
+ }
+};
+
+// Logs fields from INPUT messages.
+class InputLogExtractor : public LogExtractor {
+ void ExtractFields(const BlimpMessage& message,
+ LogFields* output) const override {
+ AddField("render_widget_id", message.input().render_widget_id(), output);
+ }
+};
+
// Logs fields from RENDER_WIDGET messages.
class RenderWidgetLogExtractor : public LogExtractor {
void ExtractFields(const BlimpMessage& message,
@@ -190,9 +207,9 @@ class NullLogExtractor : public LogExtractor {
BlimpMessageLogger::BlimpMessageLogger() {
AddHandler("COMPOSITOR", BlimpMessage::COMPOSITOR,
- make_scoped_ptr(new NullLogExtractor));
+ make_scoped_ptr(new CompositorLogExtractor));
AddHandler("INPUT", BlimpMessage::INPUT,
- make_scoped_ptr(new NullLogExtractor));
+ make_scoped_ptr(new InputLogExtractor));
AddHandler("NAVIGATION", BlimpMessage::NAVIGATION,
make_scoped_ptr(new NavigationLogExtractor));
AddHandler("PROTOCOL_CONTROL", BlimpMessage::PROTOCOL_CONTROL,
« no previous file with comments | « blimp/client/feature/compositor/blimp_compositor_manager.cc ('k') | blimp/common/logging_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698