Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3225)

Unified Diff: blimp/client/feature/compositor/blimp_compositor_manager.cc

Issue 1840843005: blimp: Add logging for compositor and render widget feature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Haibin's comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/feature/compositor/blimp_compositor.cc ('k') | blimp/common/logging.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/feature/compositor/blimp_compositor_manager.cc
diff --git a/blimp/client/feature/compositor/blimp_compositor_manager.cc b/blimp/client/feature/compositor/blimp_compositor_manager.cc
index 4e5e67fea276b4c6c378697c7caf0ca01c5a5119..92eee26a91377f8be5101cad4091fe196d545c4b 100644
--- a/blimp/client/feature/compositor/blimp_compositor_manager.cc
+++ b/blimp/client/feature/compositor/blimp_compositor_manager.cc
@@ -78,6 +78,8 @@ scoped_ptr<BlimpCompositor> BlimpCompositorManager::CreateBlimpCompositor(
void BlimpCompositorManager::OnRenderWidgetCreated(int render_widget_id) {
DCHECK(!GetCompositor(render_widget_id));
+ VLOG(1) << "Creating Blimp Compositor for render widget: "
haibinlu 2016/03/31 19:06:08 remove? duplicate msg with RenderWidgetLogExtracto
Khushal 2016/03/31 19:11:46 Done.
+ << render_widget_id;
compositors_[render_widget_id] = CreateBlimpCompositor(render_widget_id,
this);
@@ -89,6 +91,8 @@ void BlimpCompositorManager::OnRenderWidgetInitialized(int render_widget_id) {
return;
if (active_compositor_) {
+ VLOG(1) << "Hiding currently active compositor for render widget: "
+ << active_compositor_->render_widget_id();
active_compositor_->SetVisible(false);
active_compositor_->ReleaseAcceleratedWidget();
}
@@ -96,11 +100,13 @@ void BlimpCompositorManager::OnRenderWidgetInitialized(int render_widget_id) {
active_compositor_ = GetCompositor(render_widget_id);
DCHECK(active_compositor_);
+ VLOG(1) << "Activating compositor for render widget: " << render_widget_id;
haibinlu 2016/03/31 19:06:08 remove? duplicate msg with RenderWidgetLogExtracto
Khushal 2016/03/31 19:11:46 Done.
active_compositor_->SetVisible(visible_);
active_compositor_->SetAcceleratedWidget(window_);
}
void BlimpCompositorManager::OnRenderWidgetDeleted(int render_widget_id) {
+ VLOG(1) << "Destroying compositor for render widget: " << render_widget_id;
haibinlu 2016/03/31 19:06:08 remove? duplicate msg with RenderWidgetLogExtracto
Khushal 2016/03/31 19:11:46 Done.
CompositorMap::const_iterator it = compositors_.find(render_widget_id);
DCHECK(it != compositors_.end());
@@ -114,6 +120,8 @@ void BlimpCompositorManager::OnRenderWidgetDeleted(int render_widget_id) {
void BlimpCompositorManager::OnCompositorMessageReceived(
int render_widget_id,
scoped_ptr<cc::proto::CompositorMessage> message) {
+ VLOG(1) << "Compositor message received for render_widget: "
haibinlu 2016/03/31 19:06:08 remove? duplicate msg with CompositorLogExtractor
Khushal 2016/03/31 19:11:46 Done.
+ << render_widget_id;
BlimpCompositor* compositor = GetCompositor(render_widget_id);
DCHECK(compositor);
« no previous file with comments | « blimp/client/feature/compositor/blimp_compositor.cc ('k') | blimp/common/logging.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698