Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: base/metrics/sparse_histogram.h

Issue 1840843004: Improve efficiency of persistent sparse histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@improved-pma-iterator
Patch Set: added comment clarifying loop behavior Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/persistent_sample_map_unittest.cc ('k') | base/metrics/sparse_histogram.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/sparse_histogram.h
diff --git a/base/metrics/sparse_histogram.h b/base/metrics/sparse_histogram.h
index f0296cbb1e1b1a2988020339df236943dc5b6986..da373a287a5c9e9c2cffabc239714093aed46477 100644
--- a/base/metrics/sparse_histogram.h
+++ b/base/metrics/sparse_histogram.h
@@ -51,7 +51,7 @@ namespace base {
} while (0)
class HistogramSamples;
-class PersistentMemoryAllocator;
+class PersistentHistogramAllocator;
class BASE_EXPORT SparseHistogram : public HistogramBase {
public:
@@ -61,7 +61,7 @@ class BASE_EXPORT SparseHistogram : public HistogramBase {
// Create a histogram using data in persistent storage.
static std::unique_ptr<HistogramBase> PersistentCreate(
- PersistentMemoryAllocator* allocator,
+ PersistentHistogramAllocator* allocator,
const std::string& name,
HistogramSamples::Metadata* meta,
HistogramSamples::Metadata* logged_meta);
@@ -91,7 +91,7 @@ class BASE_EXPORT SparseHistogram : public HistogramBase {
// Clients should always use FactoryGet to create SparseHistogram.
explicit SparseHistogram(const std::string& name);
- SparseHistogram(PersistentMemoryAllocator* allocator,
+ SparseHistogram(PersistentHistogramAllocator* allocator,
const std::string& name,
HistogramSamples::Metadata* meta,
HistogramSamples::Metadata* logged_meta);
« no previous file with comments | « base/metrics/persistent_sample_map_unittest.cc ('k') | base/metrics/sparse_histogram.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698