base/metrics/persistent_memory_allocator.cc - Issue 1840843004: Improve efficiency of persistent sparse histograms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/persistent_memory_allocator.cc

Issue 1840843004: Improve efficiency of persistent sparse histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@improved-pma-iterator

Patch Set: added comment clarifying loop behavior Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/persistent_memory_allocator.cc

diff --git a/base/metrics/persistent_memory_allocator.cc b/base/metrics/persistent_memory_allocator.cc

index 6edbc2fee74d7660fe8eb5b19ad53c5321c650f9..604971d3bcd5dfc6f53a01e1df13b4ea5849e88c 100644

--- a/base/metrics/persistent_memory_allocator.cc

+++ b/base/metrics/persistent_memory_allocator.cc

@@ -116,8 +116,6 @@ struct PersistentMemoryAllocator::SharedMetadata {

const PersistentMemoryAllocator::Reference

PersistentMemoryAllocator::kReferenceQueue =

offsetof(SharedMetadata, queue);

-const PersistentMemoryAllocator::Reference

- PersistentMemoryAllocator::kReferenceNull = 0;

PersistentMemoryAllocator::Iterator::Iterator(

const PersistentMemoryAllocator* allocator)

« no previous file with comments | « base/metrics/persistent_memory_allocator.h ('k') | base/metrics/persistent_sample_map.h » ('j') | no next file with comments »