Handle redirected constructors when generating summaries from ASTs.

pkg/analyzer/test/src/summary/summary_common.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.src.summary.summary_common;
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/dart/scanner/reader.dart';
@@ skipping 3927 matching lines @@
 }
 class D {
   final x;
   D() : x = new C();
 }
 ''');
     expect(findClass('C').executables[0].constCycleSlot, 0);
     expect(findClass('D').executables[0].constCycleSlot, 0);
   }
 
+  test_constructorCycle_redirectToImplicitConstructor() {
+    serializeLibraryText(
+        '''
+class C {
+  const factory C() = D;
+}
+class D extends C {}
+''',
+        allowErrors: true);
+    checkConstCycle('C', hasCycle: false);
+  }
+
+  test_constructorCycle_redirectToNonConstConstructor() {
+    // It's not valid Dart but we need to make sure it doesn't crash
+    // summary generation.
+    serializeLibraryText(
+        '''
+class C {
+  const factory C() = D;
+}
+class D extends C {
+  D();
+}
+''',
+        allowErrors: true);
+    checkConstCycle('C', hasCycle: false);
+  }
+
+  test_constructorCycle_redirectToSymbolConstructor() {
+    // The symbol constructor has some special case behaviors in analyzer.
+    // Make sure those special case behaviors don't cause problems.
+    serializeLibraryText(
+        '''
+class C {
+  const factory C(String name) = Symbol;
+}
+''',
+        allowErrors: true);
+    checkConstCycle('C', hasCycle: false);
+  }
+
   test_constructorCycle_referenceToClass() {
     serializeLibraryText('''
 class C {
   final x;
   const C() : x = C;
 }
 ''');
     checkConstCycle('C', hasCycle: false);
   }
 
@@ skipping 123 matching lines @@
     addNamedSource('/a.dart', '');
     serializeLibraryText(
         '''
 import 'a.dart' as a;
 class C {
   final x;
   const C() : x = a.foo;
 }
 ''',
         allowErrors: true);
+    checkConstCycle('C', hasCycle: false);
   }
 
   test_constructorCycle_referenceToUndefinedName_viaPrefix_nonExistentFile() {
     // It's not valid Dart but we need to make sure it doesn't crash
     // summary generation.
     allowMissingFiles = true;
     serializeLibraryText(
         '''
 import 'a.dart' as a;
 class C {
   final x;
   const C() : x = a.foo;
 }
 ''',
         allowErrors: true);
+    checkConstCycle('C', hasCycle: false);
+  }
+
+  test_constructorCycle_viaFactoryRedirect() {
+    serializeLibraryText(
+        '''
+class C {
+  const C();
+  const factory C.named() = D;
+}
+class D extends C {
+  final x;
+  const D() : x = y;
+}
+const y = const C.named();
+''',
+        allowErrors: true);
+    checkConstCycle('C', hasCycle: false);
+    checkConstCycle('C', name: 'named');
+    checkConstCycle('D');
   }
 
   test_constructorCycle_viaFinalField() {
     serializeLibraryText(
         '''
 class C {
   final x = const C();
   const C();
 }
 ''',
         allowErrors: true);
     checkConstCycle('C');
   }
 
   test_constructorCycle_viaNamedConstructor() {
     serializeLibraryText('''
 class C {
   final x;
   const C() : x = const D.named();
 }
 class D {
   final x;
   const D.named() : x = const C();
 }
 ''');
     checkConstCycle('C');
     checkConstCycle('D', name: 'named');
   }
 
+  test_constructorCycle_viaOrdinaryRedirect() {
+    serializeLibraryText('''
+class C {
+  final x;
+  const C() : this.named();
+  const C.named() : x = const C();
+}
+''');
+    checkConstCycle('C');
+    checkConstCycle('C', name: 'named');
+  }
+
+  test_constructorCycle_viaOrdinaryRedirect_suppressSupertype() {
+    // Since C redirects to C.named, it doesn't implicitly refer to B's unnamed
+    // constructor.  Therefore there is no cycle.
+    serializeLibraryText('''
+class B {
+  final x;
+  const B() : x = const C();
+  const B.named() : x = null;
+}
+class C extends B {
+  const C() : this.named();
+  const C.named() : super.named();
+}
+''');
+    checkConstCycle('B', hasCycle: false);
+    checkConstCycle('B', name: 'named', hasCycle: false);
+    checkConstCycle('C', hasCycle: false);
+    checkConstCycle('C', name: 'named', hasCycle: false);
+  }
+
   test_constructorCycle_viaStaticField_inOtherClass() {
     serializeLibraryText(
         '''
 class C {
   final x;
   const C() : x = D.y;
 }
 class D {
   static const y = const C();
 }
@@ skipping 3978 matching lines @@
 class _PrefixExpectation {
   final ReferenceKind kind;
   final String name;
   final String absoluteUri;
   final String relativeUri;
   final int numTypeParameters;
 
   _PrefixExpectation(this.kind, this.name,
       {this.absoluteUri, this.relativeUri, this.numTypeParameters: 0});
 }