Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3024)

Unified Diff: content/shell/renderer/layout_test/layout_test_content_renderer_client.cc

Issue 1840823002: Extract WebViewClient implementation out of WebTestProxyBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@separate-pixel-dump-code
Patch Set: Expanding a comment + an IWYU fix. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/renderer/layout_test/blink_test_runner.cc ('k') | content/test/layouttest_support.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
diff --git a/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc b/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
index 489339fd7130f600e3da2232beba5c8fc12c6451..37bcec4b5a16dcc959e812b54c549a0cc3c8768f 100644
--- a/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
+++ b/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
@@ -56,6 +56,9 @@ void WebTestProxyCreated(RenderView* render_view,
LayoutTestRenderProcessObserver::GetInstance()->SetTestDelegate(
test_runner);
}
+ proxy->set_view_test_client(LayoutTestRenderProcessObserver::GetInstance()
+ ->test_interfaces()
+ ->CreateWebViewTestClient(proxy));
proxy->SetInterfaces(
LayoutTestRenderProcessObserver::GetInstance()->test_interfaces());
test_runner->proxy()->SetDelegate(
@@ -66,7 +69,7 @@ void WebFrameTestProxyCreated(RenderFrame* render_frame,
test_runner::WebFrameTestProxyBase* proxy) {
proxy->set_test_client(LayoutTestRenderProcessObserver::GetInstance()
->test_interfaces()
- ->GetWebFrameTestClient());
+ ->CreateWebFrameTestClient());
}
} // namespace
@@ -93,6 +96,10 @@ void LayoutTestContentRendererClient::RenderViewCreated(
RenderView* render_view) {
new ShellRenderViewObserver(render_view);
+ test_runner::WebTestProxyBase* proxy = GetWebTestProxyBase(render_view);
+ proxy->set_web_widget(render_view->GetWebView());
+ proxy->set_web_view(render_view->GetWebView());
+
BlinkTestRunner* test_runner = BlinkTestRunner::Get(render_view);
test_runner->Reset(false /* for_new_test */);
render_view->GetWebView()->setSpellCheckClient(
« no previous file with comments | « content/shell/renderer/layout_test/blink_test_runner.cc ('k') | content/test/layouttest_support.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698