Always ignore navigation in Document::detach() in LocalFrame::navigate()

third_party/WebKit/Source/core/frame/LocalFrame.cpp

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
index c08c5dea4a5a2d7bf32a6ce1c02ed09b318931e0..c99a3e6334b0b454fc4769765556643af6ca9a69 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
@@ -282,7 +282,7 @@ void LocalFrame::navigate(Document& originDocument, const KURL& url, bool replac
     // TODO(japhet): This special case is also necessary for behavior asserted by some extensions tests.
     // Using NavigationScheduler::scheduleNavigationChange causes the navigation to be flagged as a
     // client redirect, which is observable via the webNavigation extension api.
-    if (isMainFrame() && !m_loader.stateMachine()->committedFirstRealDocumentLoad()) {
+    if (isNavigationAllowed() && isMainFrame() && !m_loader.stateMachine()->committedFirstRealDocumentLoad()) {

[Nate Chapin, 2016/03/28 21:55:43]

Would it be cleaner to call the other LocalFrame::navigate() in this if() branch
instead of adding the isNavigationAllowed() check here?

[dcheng, 2016/03/28 22:24:36]

Done.

         FrameLoadRequest request(&originDocument, url);
         request.resourceRequest().setHasUserGesture(userGestureStatus == UserGestureStatus::Active);
         m_loader.load(request);