Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1840743004: Turn on seamless cubemap by default on Desktop GL for ES3. (Closed)

Created:
4 years, 8 months ago by Zhenyao Mo
Modified:
4 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit), bajones
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on seamless cubemap by default on Desktop GL for ES3. BUG=597794 TEST=deqp/texturefiltering_cube_* R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/da412cef54b24fb6013f6ec5ad89327bf1151b80 Cr-Commit-Position: refs/heads/master@{#383615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -11 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +23 lines, -11 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840743004/1
4 years, 8 months ago (2016-03-28 21:59:04 UTC) #3
Zhenyao Mo
piman: please take another look. Turning seamless cubemap on broke Mac Intel. I need to ...
4 years, 8 months ago (2016-03-28 22:00:16 UTC) #4
Ken Russell (switch to Gerrit)
LGTM FWIW. Could you add a little more description of what the failure looks like ...
4 years, 8 months ago (2016-03-28 22:15:36 UTC) #6
Zhenyao Mo
On 2016/03/28 22:15:36, Ken Russell wrote: > LGTM FWIW. > > Could you add a ...
4 years, 8 months ago (2016-03-28 22:18:37 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-28 23:33:07 UTC) #9
piman
lgtm
4 years, 8 months ago (2016-03-28 23:33:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840743004/1
4 years, 8 months ago (2016-03-28 23:49:37 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 23:54:31 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 23:55:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da412cef54b24fb6013f6ec5ad89327bf1151b80
Cr-Commit-Position: refs/heads/master@{#383615}

Powered by Google App Engine
This is Rietveld 408576698