Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1840743003:
Not build glue layer if use_webview_internal_framework is set (Closed)
|
Created:
4 years, 8 months ago by michaelbai Modified:
4 years, 8 months ago Reviewers:
sgurun-gerrit only CC:
chromium-reviews, android-webview-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionNot build glue layer if use_webview_internal_framework is set
BUG=586173
Committed: https://crrev.com/0f54bb4beacd40dec34b2873b758fc1dcabaae06
Cr-Commit-Position: refs/heads/master@{#383809}
Patch Set 1 #Patch Set 2 : fix unused variable #Messages
Total messages: 18 (9 generated)
The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840743003/1
Description was changed from ========== Not build glue layer if use_webview_internal_framework is set BUG=586173 ========== to ========== Not build glue layer if use_webview_internal_framework is set BUG=586173 ==========
michaelbai@chromium.org changed reviewers: + sgurun@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840743003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840743003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/03/28 20:15:40, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. Himm ok, yo mean not build *public* glue layer, otherwise this would put me on a confusion path. lgtm
The CQ bit was checked by michaelbai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840743003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840743003/20001
Message was sent while issue was closed.
Description was changed from ========== Not build glue layer if use_webview_internal_framework is set BUG=586173 ========== to ========== Not build glue layer if use_webview_internal_framework is set BUG=586173 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Not build glue layer if use_webview_internal_framework is set BUG=586173 ========== to ========== Not build glue layer if use_webview_internal_framework is set BUG=586173 Committed: https://crrev.com/0f54bb4beacd40dec34b2873b758fc1dcabaae06 Cr-Commit-Position: refs/heads/master@{#383809} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0f54bb4beacd40dec34b2873b758fc1dcabaae06 Cr-Commit-Position: refs/heads/master@{#383809} |
