Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1840723002: String.prototype.{match,search} should do only one RegExp brand check (Closed)

Created:
4 years, 8 months ago by adamk
Modified:
4 years, 8 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

String.prototype.{match,search} should do only one RegExp brand check Previously, they would check for Symbol.match/Symbol.search, and then do another check for Symbol.match in the RegExp constructor. This patch avoids the second one by skipping the RegExp constructor, as the spec does. Committed: https://crrev.com/0fdf32556c97068a03273606fecdac287325b4fb Cr-Commit-Position: refs/heads/master@{#35085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -3 lines) Patch
M src/js/regexp.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/js/string.js View 4 chunks +9 lines, -3 lines 0 comments Download
A test/mjsunit/es6/pattern-brand-check.js View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
4 years, 8 months ago (2016-03-28 17:55:22 UTC) #2
Dan Ehrenberg
lgtm
4 years, 8 months ago (2016-03-28 18:46:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840723002/1
4 years, 8 months ago (2016-03-28 18:50:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 18:52:39 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 18:53:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fdf32556c97068a03273606fecdac287325b4fb
Cr-Commit-Position: refs/heads/master@{#35085}

Powered by Google App Engine
This is Rietveld 408576698