[V8] Add FunctionMirror.prototype.contextDebugId method

[V8] Add FunctionMirror.prototype.contextDebugId method

This method returns contextDebugId for function. We can't use context_data from FunctionMirror.prototype.script because it can be incorrect when compilation cache is used and one script object was used for JSFunctions in different contexts.

BUG=chromium:595206
LOG=Y
R=yangguo@chromium.org

Committed: https://crrev.com/2bcbd1e8e28efd97961222785dfe40fcd2581c55
Cr-Commit-Position: refs/heads/master@{#35117}

[kozy, 2016-03-28 17:52:09]

Description was changed from

==========
[V8] Add FunctionMirror.prototype.contextDebugId method

This method returns contextDebugId for function. We can't use context_data from
FunctionMirror.prototype.script because it can be incorrect when compilation
cache is used.

BUG=chromium:595206
LOG=Y
R=yangguo@chromium.org
==========

to

==========
[V8] Add FunctionMirror.prototype.contextDebugId method

This method returns contextDebugId for function. We can't use context_data from
FunctionMirror.prototype.script because it can be incorrect when compilation
cache is used and one script object was used for JSFunctions in different
contexts.

BUG=chromium:595206
LOG=Y
R=yangguo@chromium.org
==========

[kozy, 2016-03-28 17:52:20]

Yang, please take a look.

[Yang, 2016-03-29 11:52:17]

It seems to me that ScriptMirror.context() is generally to be avoided due to
compilation cache. Can we rip that out, including the place where we set the
debug-id in CompileToplevel?

https://codereview.chromium.org/1840713002/diff/1/src/debug/mirrors.js
File src/debug/mirrors.js (right):

https://codereview.chromium.org/1840713002/diff/1/src/debug/mirrors.js#newcod...
src/debug/mirrors.js:1040: FunctionMirror.prototype.contextDebugId = function()
{
Why do we not return a ContextMirror like ScriptMirror.context() does?

[kozy, 2016-03-29 17:45:15]

Yes, there is issue with using context_data on ScriptMirror. We use it for
reporting loaded scripts on DevTools shown while processing scripts from
Debug.scripts call.
We need to have a map between script and native contexts where script was used,
probably we can store list of context_datas on script instead last one.
I'm going to investigate this issue in next CL.

https://codereview.chromium.org/1840713002/diff/1/src/debug/mirrors.js
File src/debug/mirrors.js (right):

https://codereview.chromium.org/1840713002/diff/1/src/debug/mirrors.js#newcod...
src/debug/mirrors.js:1040: FunctionMirror.prototype.contextDebugId = function()
{
On 2016/03/29 11:52:17, Yang wrote:
> Why do we not return a ContextMirror like ScriptMirror.context() does?

Done.

[Yang, 2016-03-29 17:50:45]

On 2016/03/29 17:45:15, kozyatinskiy wrote:
> Yes, there is issue with using context_data on ScriptMirror. We use it for
> reporting loaded scripts on DevTools shown while processing scripts from
> Debug.scripts call.
> We need to have a map between script and native contexts where script was
used,
> probably we can store list of context_datas on script instead last one.
> I'm going to investigate this issue in next CL.
> 
> https://codereview.chromium.org/1840713002/diff/1/src/debug/mirrors.js
> File src/debug/mirrors.js (right):
> 
>
https://codereview.chromium.org/1840713002/diff/1/src/debug/mirrors.js#newcod...
> src/debug/mirrors.js:1040: FunctionMirror.prototype.contextDebugId =
function()
> {
> On 2016/03/29 11:52:17, Yang wrote:
> > Why do we not return a ContextMirror like ScriptMirror.context() does?
> 
> Done.

lgtm

[kozy, 2016-03-29 17:51:22]

The CQ bit was checked by kozyatinskiy@chromium.org

[Yang, 2016-03-29 17:51:23]

On 2016/03/29 17:50:45, Yang wrote:
> On 2016/03/29 17:45:15, kozyatinskiy wrote:
> > Yes, there is issue with using context_data on ScriptMirror. We use it for
> > reporting loaded scripts on DevTools shown while processing scripts from
> > Debug.scripts call.
> > We need to have a map between script and native contexts where script was
> used,
> > probably we can store list of context_datas on script instead last one.
> > I'm going to investigate this issue in next CL.
> > 
> > https://codereview.chromium.org/1840713002/diff/1/src/debug/mirrors.js
> > File src/debug/mirrors.js (right):
> > 
> >
>
https://codereview.chromium.org/1840713002/diff/1/src/debug/mirrors.js#newcod...
> > src/debug/mirrors.js:1040: FunctionMirror.prototype.contextDebugId =
> function()
> > {
> > On 2016/03/29 11:52:17, Yang wrote:
> > > Why do we not return a ContextMirror like ScriptMirror.context() does?
> > 
> > Done.
> 
> lgtm

maybe each script should store a weak fixed array of contexts instead of their
ids.

[commit-bot: I haz the power, 2016-03-29 17:51:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1840713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1840713002/20001

[commit-bot: I haz the power, 2016-03-29 18:19:28]

Description was changed from

==========
[V8] Add FunctionMirror.prototype.contextDebugId method

This method returns contextDebugId for function. We can't use context_data from
FunctionMirror.prototype.script because it can be incorrect when compilation
cache is used and one script object was used for JSFunctions in different
contexts.

BUG=chromium:595206
LOG=Y
R=yangguo@chromium.org
==========

to

==========
[V8] Add FunctionMirror.prototype.contextDebugId method

This method returns contextDebugId for function. We can't use context_data from
FunctionMirror.prototype.script because it can be incorrect when compilation
cache is used and one script object was used for JSFunctions in different
contexts.

BUG=chromium:595206
LOG=Y
R=yangguo@chromium.org
==========

[commit-bot: I haz the power, 2016-03-29 18:19:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-29 18:21:13]

Description was changed from

==========
[V8] Add FunctionMirror.prototype.contextDebugId method

This method returns contextDebugId for function. We can't use context_data from
FunctionMirror.prototype.script because it can be incorrect when compilation
cache is used and one script object was used for JSFunctions in different
contexts.

BUG=chromium:595206
LOG=Y
R=yangguo@chromium.org
==========

to

==========
[V8] Add FunctionMirror.prototype.contextDebugId method

This method returns contextDebugId for function. We can't use context_data from
FunctionMirror.prototype.script because it can be incorrect when compilation
cache is used and one script object was used for JSFunctions in different
contexts.

BUG=chromium:595206
LOG=Y
R=yangguo@chromium.org

Committed: https://crrev.com/2bcbd1e8e28efd97961222785dfe40fcd2581c55
Cr-Commit-Position: refs/heads/master@{#35117}
==========

[commit-bot: I haz the power, 2016-03-29 18:21:14]

Patchset 2 (id:??) landed as
https://crrev.com/2bcbd1e8e28efd97961222785dfe40fcd2581c55
Cr-Commit-Position: refs/heads/master@{#35117}