Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: tools/tickprocessor.js

Issue 1840633002: tools: fix tickprocessor Cpp symbols on mac (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: add reviwer? Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/tickprocessor.js
diff --git a/tools/tickprocessor.js b/tools/tickprocessor.js
index 600d2eeb7b79dc3bcee56f183e0ec3c2347e83f6..e62720bd8a0fe30f783fe391bf776632049ad6f2 100644
--- a/tools/tickprocessor.js
+++ b/tools/tickprocessor.js
@@ -757,8 +757,11 @@ inherits(MacCppEntriesProvider, UnixCppEntriesProvider);
MacCppEntriesProvider.prototype.loadSymbols = function(libName) {
this.parsePos = 0;
libName = this.targetRootFS + libName;
+
+ // It seems that in OS X `nm` thinks that `-f` is a format option, not a
+ // "flat" display option flag.
noordhuis 2016/03/28 18:32:24 It sounds like you were picking up the GNU version
fedor.indutny 2016/03/28 21:20:46 It could be this, but sounds very unlikely conside
Michael Achenbach 2016/04/06 06:53:52 I logged onto a random mac 10.9.5 bot and typed: w
fedor.indutny 2016/04/07 15:07:41 I guess there are some differences between `nm` su
try {
- this.symbols = [os.system(this.nmExec, ['-n', '-f', libName], -1, -1), ''];
+ this.symbols = [os.system(this.nmExec, ['-n', libName], -1, -1), ''];
} catch (e) {
// If the library cannot be found on this system let's not panic.
this.symbols = '';
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698