Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc

Issue 1840573003: Add request method of the last data reduction proxy bypass to user feedback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc
diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc b/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc
index c8766f98b8e748f7d9dc5017a0930c8dbbcb1ebb..4bdda15ef3ffcd46c7c656fe7051c4b2c57f0664 100644
--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc
+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store_unittest.cc
@@ -259,6 +259,8 @@ TEST_F(DataReductionProxyEventStoreTest, TestFeedbackLastBypassEventFullURL) {
sanitized_event->SetString("bypass_seconds", "40");
bypass_params->SetString("url", "http://www.foo.com/bar?baz=1234");
sanitized_event->SetString("url", "http://www.foo.com/bar");
+ bypass_params->SetString("method", "GET");
+ sanitized_event->SetString("method", "GET");
bypass_event->Set("params", std::move(bypass_params));
std::string sanitized_output;
@@ -289,6 +291,8 @@ TEST_F(DataReductionProxyEventStoreTest, TestFeedbackLastBypassEventHostOnly) {
sanitized_event->SetString("bypass_seconds", "40");
bypass_params->SetString("url", "http://www.foo.com/bar?baz=1234");
sanitized_event->SetString("url", "www.foo.com");
+ bypass_params->SetString("method", "GET");
+ sanitized_event->SetString("method", "GET");
bypass_event->Set("params", std::move(bypass_params));
std::string sanitized_output;
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698