chrome/android/java/res/values/dimens.xml - Issue 1840513002: Redesign sign in and sign in confirmation screens for Narnia 2.0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/values/dimens.xml

Issue 1840513002: Redesign sign in and sign in confirmation screens for Narnia 2.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/layout/account_signin_view.xml ('K') | « chrome/android/java/res/values/colors.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/firstrun/AccountFirstRunFragment.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/signin/AccountListAdapter.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/values/dimens.xml

diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml

index 5958b726bbc08e5bb43dd4e681011c815b9db7e7..70c64ce7853c29028fa2787ecebc751e33ac933a 100644

--- a/chrome/android/java/res/values/dimens.xml

+++ b/chrome/android/java/res/values/dimens.xml

@@ -177,11 +177,7 @@

<!-- The Account Signin page appears in the First Run Experience (amongst other places), so uses

a lot of the fre_* dimensions for consistency. -->

- <dimen name="signin_checkmark_size">38dp</dimen>

-

- <dimen name="sign_in_promo_padding_bottom">16dp</dimen>