Chromium Code Reviews Chromium Code Reviews
Issue 1840513002:
Redesign sign in and sign in confirmation screens for Narnia 2.0 (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. |
| 3 | 3 |
| 4 Use of this source code is governed by a BSD-style license that can be | 4 Use of this source code is governed by a BSD-style license that can be |
| 5 found in the LICENSE file. | 5 found in the LICENSE file. |
| 6 --> | 6 --> |
| 7 <org.chromium.chrome.browser.signin.AccountSigninView | 7 <org.chromium.chrome.browser.signin.AccountSigninView |
| 8 xmlns:android="http://schemas.android.com/apk/res/android" | 8 xmlns:android="http://schemas.android.com/apk/res/android" |
| 9 xmlns:chrome="http://schemas.android.com/apk/res-auto" | 9 xmlns:chrome="http://schemas.android.com/apk/res-auto" |
| 10 android:layout_width="match_parent" | 10 android:layout_width="match_parent" |
| 11 android:layout_height="match_parent"> | 11 android:layout_height="match_parent" |
| 12 | 12 android:background="@color/signin_body_background"> |
| 13 <ScrollView | 13 |
| 14 <FrameLayout | |
| 14 android:layout_width="match_parent" | 15 android:layout_width="match_parent" |
| 15 android:layout_height="match_parent" | 16 android:layout_height="match_parent" |
| 16 android:layout_marginBottom="72dp" | 17 android:layout_marginBottom="52dp"> |
| 17 android:fillViewport="true"> | 18 |
| 18 | 19 <!-- The view allow user to choose account to sign in --> |
|
newt (away)
2016/04/13 18:13:30
nit: fix grammar in comment (and same below)
gogerald1
2016/04/13 21:33:12
Done.
| |
| 19 <LinearLayout | 20 <LinearLayout |
|
newt (away)
2016/04/13 18:13:30
remove trailing space
gogerald1
2016/04/13 21:33:12
Done.
| |
| 20 android:id="@+id/fre_main_layout" | 21 android:id="@+id/signin_choose_account_view" |
| 21 android:layout_width="match_parent" | 22 android:layout_width="match_parent" |
| 22 android:layout_height="wrap_content" | 23 android:layout_height="match_parent" |
| 23 android:orientation="vertical" | 24 android:orientation="vertical"> |
| 24 android:gravity="center_horizontal"> | 25 |
| 25 | 26 <!-- The layout_width/layout_height is set to 16/9 dynamically in Ja va --> |
| 26 <TextView | 27 <TextView |
| 27 android:id="@+id/title" | 28 android:id="@+id/signin_title" |
| 28 android:text="@string/signin_set_up_chrome" | |
| 29 style="@style/FreTitle"/> | |
| 30 | |
| 31 <!-- The orientation of this view is changed dynamically to give a n icer layout when in | |
| 32 landscape mode on devices with small screens. --> | |
| 33 <LinearLayout | |
| 34 android:id="@+id/fre_image_and_content" | |
| 35 android:layout_width="match_parent" | 29 android:layout_width="match_parent" |
| 36 android:layout_height="wrap_content" | 30 android:layout_height="wrap_content" |
| 37 android:orientation="vertical" | 31 android:gravity="bottom" |
| 38 android:gravity="center_horizontal" | 32 android:paddingStart="16dp" |
| 39 android:layout_marginTop="@dimen/fre_vertical_spacing"> | 33 android:paddingEnd="16dp" |
| 40 | 34 android:paddingBottom="16dp" |
| 41 <org.chromium.chrome.browser.firstrun.ImageCarousel | 35 android:background="@color/signin_head_background" |
| 42 android:id="@+id/image" | 36 android:textColor="@color/default_text_color" |
| 43 android:layout_width="@dimen/signin_image_carousel_width" | 37 android:textSize="@dimen/fre_title_text_size" |
| 44 android:layout_height="@dimen/fre_image_height" /> | 38 android:text="@string/sign_in_to_chrome"/> |
| 45 | 39 |
| 40 <View | |
| 41 android:layout_width="match_parent" | |
| 42 android:layout_height="1dp" | |
| 43 android:background="@color/signin_border_line_color" | |
| 44 android:alpha="0.08"/> | |
| 45 | |
| 46 <org.chromium.chrome.browser.signin.AccountListView | |
| 47 android:id="@+id/signin_account_list" | |
| 48 android:layout_width="match_parent" | |
| 49 android:layout_height="wrap_content" | |
| 50 android:divider="@null" | |
| 51 android:dividerHeight="0dp" | |
| 52 android:scrollbars="none" | |
| 53 android:requiresFadingEdge="vertical" | |
| 54 android:fadingEdgeLength="48dp"/> | |
| 55 </LinearLayout> | |
| 56 | |
| 57 <!-- The view allow user to confirm signed in account, sync and service personalization --> | |
| 58 <org.chromium.chrome.browser.signin.AccountSigninConfirmationView | |
| 59 android:id="@+id/signin_confirmation_view" | |
| 60 android:layout_width="match_parent" | |
| 61 android:layout_height="match_parent" | |
| 62 android:scrollbars="none" | |
| 63 android:requiresFadingEdge="vertical" | |
| 64 android:fadingEdgeLength="48dp" | |
| 65 android:visibility="gone"> | |
| 66 | |
|
newt (away)
2016/04/13 18:13:30
remove trailing space
gogerald1
2016/04/13 21:33:13
Done.
| |
| 67 <RelativeLayout | |
| 68 android:layout_width="match_parent" | |
| 69 android:layout_height="wrap_content" | |
| 70 android:orientation="vertical"> | |
| 71 | |
| 72 <!-- The layout_width/layout_height is set to 16/9 dynamically i n Java --> | |
| 46 <LinearLayout | 73 <LinearLayout |
| 47 android:id="@+id/fre_content_wrapper" | 74 android:id="@+id/signin_confirmation_head" |
| 75 android:layout_width="match_parent" | |
| 76 android:layout_height="wrap_content" | |
| 77 android:paddingStart="16dp" | |
| 78 android:paddingEnd="16dp" | |
| 79 android:background="@color/signin_head_background" | |
| 80 android:orientation="vertical"> | |
| 81 | |
| 82 <View | |
|
newt (away)
2016/04/13 18:13:30
Ah, I see why this was needed. You can actually re
gogerald1
2016/04/13 21:33:13
Done.
| |
| 83 android:layout_width="0dp" | |
| 84 android:layout_height="0dp" | |
| 85 android:layout_weight="1" | |
| 86 android:visibility="invisible"/> | |
| 87 | |
| 88 <ImageView | |
| 89 android:id="@+id/signin_account_image" | |
| 90 android:layout_width="64dp" | |
| 91 android:layout_height="64dp" | |
| 92 android:layout_marginBottom="24dp" | |
| 93 android:scaleType="fitCenter" | |
| 94 android:contentDescription="@null"/> | |
| 95 | |
| 96 <TextView | |
| 97 android:id="@+id/signin_account_name" | |
| 98 android:layout_width="match_parent" | |
| 99 android:layout_height="wrap_content" | |
| 100 android:layout_marginBottom="8dp" | |
| 101 android:textColor="@color/default_text_color" | |
| 102 android:textSize="@dimen/fre_title_text_size"/> | |
| 103 | |
| 104 <TextView | |
| 105 android:id="@+id/signin_account_email" | |
| 106 android:layout_width="match_parent" | |
| 107 android:layout_height="wrap_content" | |
| 108 android:layout_marginBottom="16dp" | |
| 109 android:textColor="@color/descriptive_text_color" | |
| 110 android:textSize="@dimen/fre_normal_text_size"/> | |
| 111 </LinearLayout> | |
| 112 | |
| 113 <View | |
| 114 android:id="@+id/signin_confirmation_head_body_border" | |
| 115 android:layout_width="match_parent" | |
| 116 android:layout_height="1dp" | |
| 117 android:layout_below="@id/signin_confirmation_head" | |
| 118 android:background="@color/signin_border_line_color" | |
| 119 android:alpha="0.08"/> | |
| 120 | |
| 121 <TextView | |
| 122 android:id="@+id/signin_chrome_sync_title" | |
| 123 android:layout_width="match_parent" | |
| 124 android:layout_height="wrap_content" | |
| 125 android:layout_marginTop="16dp" | |
| 126 android:layout_marginBottom="8dp" | |
| 127 android:layout_below="@id/signin_confirmation_head_body_bord er" | |
| 128 android:paddingStart="16dp" | |
| 129 android:paddingEnd="16dp" | |
| 130 android:text="@string/sync_confirmation_chrome_sync_title" | |
| 131 android:textColor="@color/default_text_color" | |
| 132 android:textSize="@dimen/fre_normal_text_size" | |
| 133 android:fontFamily="sans-serif-medium" | |
| 134 android:drawableStart="@drawable/chrome_sync_logo" | |
| 135 android:drawablePadding="16dp"/> | |
| 136 | |
| 137 <TextView | |
| 138 android:id="@+id/signin_chrome_sync_description" | |
| 139 android:layout_width="match_parent" | |
| 140 android:layout_height="wrap_content" | |
| 141 android:layout_marginBottom="16dp" | |
| 142 android:layout_below="@id/signin_chrome_sync_title" | |
| 143 android:paddingStart="56dp" | |
| 144 android:paddingEnd="16dp" | |
| 145 android:lineSpacingMultiplier="1.4" | |
| 146 android:text="@string/sync_confirmation_chrome_sync_message" | |
| 147 android:textColor="@color/descriptive_text_color" | |
| 148 android:textSize="@dimen/fre_normal_text_size" /> | |
| 149 | |
| 150 <View | |
| 151 android:id="@+id/signin_confirmation_body_rule_line" | |
| 152 android:layout_width="match_parent" | |
| 153 android:layout_height="1dp" | |
| 154 android:layout_marginStart="56dp" | |
| 155 android:layout_marginEnd="16dp" | |
| 156 android:layout_below="@id/signin_chrome_sync_description" | |
| 157 android:background="@color/signin_border_line_color" | |
| 158 android:alpha="0.08"/> | |
| 159 | |
| 160 <TextView | |
| 161 android:id="@+id/signin_personalize_service_title" | |
| 162 android:layout_width="match_parent" | |
| 163 android:layout_height="wrap_content" | |
| 164 android:layout_marginTop="16dp" | |
| 165 android:layout_marginBottom="8dp" | |
| 166 android:layout_below="@id/signin_confirmation_body_rule_line " | |
| 167 android:paddingStart="16dp" | |
| 168 android:paddingEnd="16dp" | |
| 169 android:text="@string/sync_confirmation_personalize_services _title" | |
| 170 android:textColor="@color/default_text_color" | |
| 171 android:textSize="@dimen/fre_normal_text_size" | |
| 172 android:fontFamily="sans-serif-medium" | |
| 173 android:drawableStart="@drawable/googleg" | |
| 174 android:drawablePadding="16dp"/> | |
| 175 | |
| 176 <TextView | |
| 177 android:id="@+id/signin_personalize_service_description" | |
| 178 android:layout_width="match_parent" | |
| 179 android:layout_height="wrap_content" | |
| 180 android:layout_marginBottom="32dp" | |
| 181 android:layout_below="@id/signin_personalize_service_title" | |
| 182 android:paddingStart="56dp" | |
| 183 android:paddingEnd="16dp" | |
| 184 android:lineSpacingMultiplier="1.4" | |
| 185 android:text="@string/sync_confirmation_personalize_services _body" | |
| 186 android:textColor="@color/descriptive_text_color" | |
| 187 android:textSize="@dimen/fre_normal_text_size"/> | |
| 188 | |
| 189 <org.chromium.ui.widget.TextViewWithClickableSpans | |
| 190 android:id="@+id/signin_settings_control" | |
| 191 android:layout_width="match_parent" | |
| 192 android:layout_height="wrap_content" | |
| 193 android:layout_below="@id/signin_personalize_service_descrip tion" | |
| 194 android:paddingStart="16dp" | |
| 195 android:paddingEnd="16dp" | |
| 196 android:lineSpacingMultiplier="1.4" | |
| 197 android:text="@string/signin_signed_in_settings_description" | |
| 198 android:textColor="@color/descriptive_text_color" | |
| 199 android:textSize="@dimen/fre_normal_text_size" /> | |
| 200 | |
| 201 <View | |
| 202 android:id="@+id/signin_confirmation_bottom_padding" | |
|
newt (away)
2016/04/13 18:13:30
I'd remove this view and just add 36dp of bottom p
gogerald1
2016/04/13 21:33:13
Done.pad to above text view.
| |
| 48 android:layout_width="0dp" | 203 android:layout_width="0dp" |
| 49 android:layout_height="0dp" | 204 android:layout_height="36dp" |
| 50 android:layout_weight="1" | 205 android:layout_below="@id/signin_settings_control" |
| 51 android:layout_marginTop="@dimen/fre_vertical_spacing" | 206 android:visibility="invisible"/> |
| 52 android:layout_marginEnd="@dimen/fre_content_margin" | 207 </RelativeLayout> |
| 53 android:layout_marginStart="@dimen/fre_content_margin" | 208 </org.chromium.chrome.browser.signin.AccountSigninConfirmationView> |
| 54 android:orientation="vertical" > | 209 </FrameLayout> |
| 55 | 210 |
| 56 <Spinner | |
| 57 style="@style/Widget.AppCompat.Spinner.Underlined" | |
| 58 android:id="@+id/google_accounts_spinner" | |
| 59 android:layout_width="wrap_content" | |
| 60 android:layout_height="wrap_content" | |
| 61 android:layout_marginBottom="@dimen/fre_vertical_spacing " | |
| 62 android:layout_gravity="center_horizontal" | |
| 63 android:popupBackground="#ffffff" | |
| 64 android:paddingStart="0dp" | |
| 65 android:paddingEnd="0dp" | |
| 66 android:textColor="@color/fre_text_color" /> | |
| 67 | |
| 68 <TextView | |
| 69 android:id="@+id/confirm_account_email" | |
| 70 android:layout_width="wrap_content" | |
| 71 android:layout_height="wrap_content" | |
| 72 android:layout_gravity="center" | |
| 73 android:layout_marginBottom="16dp" | |
| 74 android:paddingTop="12dp" | |
| 75 android:paddingBottom="8dp" | |
| 76 android:textColor="@color/fre_text_color" | |
| 77 android:visibility="gone" /> | |
| 78 | |
| 79 <org.chromium.ui.widget.TextViewWithClickableSpans | |
| 80 android:id="@+id/description" | |
| 81 android:layout_width="wrap_content" | |
| 82 android:layout_height="wrap_content" | |
| 83 android:gravity="center" | |
| 84 android:lineSpacingMultiplier="1.4" | |
| 85 android:text="@string/signin_account_choice_description" | |
| 86 android:textColor="@color/signin_light_text_color" | |
| 87 android:textSize="@dimen/fre_normal_text_size" /> | |
| 88 </LinearLayout> | |
| 89 | |
| 90 </LinearLayout> | |
| 91 </LinearLayout> | |
| 92 </ScrollView> | |
| 93 | |
| 94 <!-- layout_height = 72dp = fre_button_bar_height + paddingTop --> | |
| 95 <LinearLayout | 211 <LinearLayout |
| 96 android:id="@+id/button_bar" | 212 android:id="@+id/button_bar" |
| 97 android:layout_width="match_parent" | 213 android:layout_width="match_parent" |
| 98 android:layout_height="72dp" | 214 android:layout_height="52dp" |
| 99 android:layout_gravity="bottom" | 215 android:layout_gravity="bottom" |
| 100 android:orientation="horizontal" | |
| 101 android:paddingTop="16dp" | |
| 102 android:paddingStart="16dp" | 216 android:paddingStart="16dp" |
| 103 android:paddingEnd="16dp" > | 217 android:paddingEnd="16dp" |
| 218 android:orientation="horizontal" > | |
| 104 | 219 |
| 105 <!--suppress ButtonStyle --> | 220 <!--suppress ButtonStyle --> |
| 106 <Button | 221 <Button |
| 107 android:id="@+id/negative_button" | 222 android:id="@+id/negative_button" |
| 108 style="@style/ButtonCompatBorderless" | 223 style="@style/ButtonCompatBorderless" |
| 109 android:layout_width="wrap_content" | 224 android:layout_width="wrap_content" |
| 110 android:layout_height="36dp" | 225 android:layout_height="36dp" |
| 111 android:text="@string/fre_skip_text" | 226 android:text="@string/fre_skip_text" |
| 112 android:textAllCaps="true" | 227 android:textAllCaps="true" |
| 113 android:textColor="@color/light_active_color" | 228 android:textColor="@color/light_active_color" |
| 114 android:textSize="14sp" | 229 android:textSize="14sp"/> |
| 115 android:layout_marginBottom="24dp" /> | |
| 116 | 230 |
| 117 <View | 231 <View |
| 118 android:layout_width="0dp" | 232 android:layout_width="0dp" |
| 119 android:layout_height="0dp" | 233 android:layout_height="0dp" |
| 120 android:layout_weight="1" | 234 android:layout_weight="1" |
| 121 android:visibility="invisible"/> | 235 android:visibility="invisible"/> |
| 122 | 236 |
| 123 <!--suppress ButtonStyle --> | 237 <!--suppress ButtonStyle --> |
| 124 <org.chromium.ui.widget.ButtonCompat | 238 <org.chromium.ui.widget.ButtonCompat |
| 125 android:id="@+id/positive_button" | 239 android:id="@+id/positive_button" |
| 126 android:layout_width="wrap_content" | 240 android:layout_width="wrap_content" |
| 127 android:layout_height="36dp" | 241 android:layout_height="36dp" |
| 128 android:text="@string/choose_account_sign_in" | 242 android:text="@string/choose_account_sign_in" |
| 129 android:textAllCaps="true" | 243 android:textAllCaps="true" |
| 130 android:textColor="@android:color/white" | 244 android:textColor="@android:color/white" |
| 131 android:textSize="14sp" | 245 android:textSize="14sp" |
| 132 chrome:buttonColor="@color/light_active_color" | 246 chrome:buttonColor="@color/light_active_color"/> |
| 133 android:layout_marginBottom="24dp" /> | |
| 134 | 247 |
| 135 <View | 248 <View |
| 136 android:id="@+id/positive_button_end_padding" | 249 android:id="@+id/positive_button_end_padding" |
| 137 android:layout_width="0dp" | 250 android:layout_width="0dp" |
| 138 android:layout_height="0dp" | 251 android:layout_height="0dp" |
| 139 android:layout_weight="1" | 252 android:layout_weight="1" |
| 140 android:visibility="gone"/> | 253 android:visibility="gone"/> |
| 141 </LinearLayout> | 254 </LinearLayout> |
| 142 | 255 |
| 143 </org.chromium.chrome.browser.signin.AccountSigninView> | 256 </org.chromium.chrome.browser.signin.AccountSigninView> |
| OLD | NEW |
