chrome/android/java/res/layout/account_signin_account_view.xml - Issue 1840513002: Redesign sign in and sign in confirmation screens for Narnia 2.0

Side by Side Diff: chrome/android/java/res/layout/account_signin_account_view.xml

Issue 1840513002: Redesign sign in and sign in confirmation screens for Narnia 2.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: new UI without CheckBox Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/chrome_sync_logo.png ('k') | chrome/android/java/res/layout/account_signin_choice_description_view.xml » ('j') | chrome/android/java/res/layout/account_signin_choice_description_view.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7 <LinearLayout

	8 xmlns:android="http://schemas.android.com/apk/res/android"

	9 android:layout_width="match_parent"

	10 android:layout_height="wrap_content"

	11 android:paddingStart="16dp"

	12 android:paddingEnd="16dp"

	13 android:orientation="horizontal">

	14

	15 <ImageView

	16 android:id="@+id/account_image"
	newt (away) 2016/04/13 18:13:30 use spaces, not tabs use spaces, not tabs gogerald1 2016/04/13 21:33:12 Done. Used four spaces instead of a tab, it may be Show quoted text On 2016/04/13 18:13:30, newt (away) wrote: > use spaces, not tabs Done. Used four spaces instead of a tab, it may be changed by my editor (sublime).
	17 android:layout_width="40dp"

	18 android:layout_height="40dp"

	19 android:layout_marginEnd="16dp"

	20 android:layout_marginTop="8dp"

	21 android:layout_marginBottom="8dp"

	22 android:contentDescription="@null"/>

	23

	24 <TextView

	25 android:id="@+id/account_name"

	26 android:layout_width="0dp"

	27 android:layout_height="56dp"
	newt (away) 2016/04/13 18:13:30 What happens if the email address is really long? What happens if the email address is really long? Does it wrap to a second line? We might want to set ellipsize="end" and maxLines=1 instead. Alternatively, you could set layout_height="wrap_content" and minHeight="56dp", then also set gravity="center_vertical" on the parent LinearLayout. That'll allow the UI to adjust nicely when the email wraps to two lines. (This would also allow you to remove the marginTop and marginBottom attributes from the two ImageViews, since those views will simply be centered vertically.) gogerald1 2016/04/13 21:33:12 Done. Show quoted text On 2016/04/13 18:13:30, newt (away) wrote: > What happens if the email address is really long? Does it wrap to a second line? > We might want to set ellipsize="end" and maxLines=1 instead. > > Alternatively, you could set layout_height="wrap_content" and minHeight="56dp", > then also set gravity="center_vertical" on the parent LinearLayout. That'll > allow the UI to adjust nicely when the email wraps to two lines. (This would > also allow you to remove the marginTop and marginBottom attributes from the two > ImageViews, since those views will simply be centered vertically.) Done.
	28 android:layout_weight="1"

	29 android:gravity="center_vertical"

	30 android:textColor="@color/default_text_color"

	31 android:textSize="@dimen/fre_normal_text_size"/>

	32

	33 <ImageView

	34 android:id="@+id/account_selection_mark"

	35 android:layout_width="24dp"

	36 android:layout_height="24dp"

	37 android:layout_marginTop="16dp"

	38 android:layout_marginBottom="16dp"

	39 android:layout_marginStart="16dp"

	40 android:src="@drawable/bookmark_check_blue"

	41 android:contentDescription="@null"

	42 android:visibility="gone"/>

	43 </LinearLayout>

OLD	NEW